Repository navigation
GH-90699: fix refleak in _testcapimodule.c - #99236
Merged
corona10 merged 2 commits intoNov 8, 2022
Merged
corona10 merged 2 commits into
corona10 merged 2 commits into
Conversation
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 5435423 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
corona10
reviewed
Nov 8, 2022
Comment thread
Modules/_testcapimodule.c
Outdated
corona10
reviewed
Nov 8, 2022
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I check the leak and solution through
./python.exe -m test test_finalization -R 3:3 Raised RLIMIT_NOFILE: 256 -> 1024 0:00:00 load avg: 3.73 Run tests sequentially 0:00:00 load avg: 3.73 [1/1] test_finalization beginning 6 repetitions 123456 ...... == Tests result: SUCCESS == 1 test OK. Total duration: 1.0 sec Tests result: SUCCESS
But please take a look at #99236 (comment) nit message.
Sorry, something went wrong.
corona10
approved these changes
Nov 8, 2022
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.