gh-99153: set location on SyntaxError for try with both except and except* - #99160
Merged
iritkatriel merged 4 commits intoNov 6, 2022
Merged
gh-99153: set location on SyntaxError for try with both except and except*#99160iritkatriel merged 4 commits into
iritkatriel merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pablogsal
approved these changes
Nov 6, 2022
pablogsal
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, @iritkatriel, I could not cleanly backport this to 3.11 due to a conflict. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-99168 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Nov 6, 2022
…and except* (pythonGH-99160) (cherry picked from commit 61b6c40)
pablogsal
pushed a commit
that referenced
this pull request
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99153.
I made it point to the try because we don't know which except or except* is incorrect.
% ./python.exe f.py File "/Users/iritkatriel/src/cpython-1/f.py", line 4 try: ^^^ SyntaxError: cannot have both 'except' and 'except*' on the same 'try'