FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-99211: Point to except/except* on syntax errors when mixing them by lysnikolaou · Pull Request #99215 · python/cpython · GitHub

/ cpython Public

gh-99211: Point to except/except* on syntax errors when mixing them - #99215

Merged
miss-islington merged 4 commits into
python:mainfrom
lysnikolaou:gh99211-point-to-except-mixing-with-star
Nov 20, 2022
ConversationCommits (4)ChecksFiles changed
Merged

gh-99211: Point to except/except* on syntax errors when mixing them#99215
miss-islington merged 4 commits into
python:mainfrom
lysnikolaou:gh99211-point-to-except-mixing-with-star

Conversation

lysnikolaou commented Nov 7, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

bedevere-bot mentioned this pull request Nov 7, 2022
Closed
iritkatriel reviewed Nov 7, 2022
View reviewed changes
Comment thread Grammar/python.gram Outdated
iritkatriel approved these changes Nov 7, 2022
View reviewed changes

iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

iritkatriel added skip news 3.11 only security fixes 3.12 only security fixes labels Nov 20, 2022

iritkatriel commented Nov 20, 2022

Copy link
Copy Markdown
Member

Added skip news because my PR had a news item that covers this (and is not too specific).

I think we should backport this to 3.11. Would you agree?

lysnikolaou commented Nov 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

I think we should backport this to 3.11. Would you agree?

Yup, I think it makes sense since #99160 was also backported.

lysnikolaou commented Nov 20, 2022

Copy link
Copy Markdown
Member Author

Also, I've pushed another change, so another quick review would be nice.

iritkatriel added the needs backport to 3.11 only security fixes label Nov 20, 2022

iritkatriel commented Nov 20, 2022

Copy link
Copy Markdown
Member

LGTM, but I'm not a parser expert.

miss-islington commented Nov 20, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.

miss-islington merged commit 9c4232a into python:main Nov 20, 2022

miss-islington commented Nov 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented Nov 20, 2022

Copy link
Copy Markdown
Contributor

Sorry, @lysnikolaou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9c4232ae8972a33f84e875cfdd866318a1233e47 3.11

miss-islington self-assigned this Nov 20, 2022

bedevere-bot commented Nov 20, 2022

Copy link
Copy Markdown

GH-99622 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 20, 2022
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Nov 20, 2022
pythongh-99211: Point to except/except* on syntax errors when mixing …
3a07421 
…them (pythonGH-99215)

Automerge-Triggered-By: GH:lysnikolaou
(cherry picked from commit 9c4232a)
lysnikolaou added a commit that referenced this pull request Nov 20, 2022
[3.11] gh-99211: Point to except/except* on syntax errors when mixing…
152a437 
… them (GH-99215) (GH-99622)

gh-99211: Point to except/except* on syntax errors when mixing them (GH-99215)

(cherry picked from commit 9c4232a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

iritkatriel iritkatriel approved these changes
pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

miss-islington

Labels

3.11 only security fixes 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL