GH-91054: Reset static events counts in code watchers tests - #99978
Merged
pablogsal merged 1 commit intoDec 4, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pythonGH-99859 introduced new buildbot failures, as reported [here](python#91054 (comment)). I was able to reproduce the failures with: ``` ./python.exe -m test -v test_capi.test_watchers -m "*TestCodeObjectWatchers*" -R 3:3 ``` The root cause appears to be to static events counters used in the tests, when running the tests with repetitions (using the same interpreter state), the counts from the first test run affected the next runs. This fixes it by resetting the counts when adding and clearing test watchers.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 5a53c06 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks a lot for the quick fix @itamaro! I will merge this if confirmed that this fixes the buildbots |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The two buildbot failures are unrelated and already exist on main: |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Merging this as this fixes most of the problems. Thanks a lot again @itamaro |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-99859 introduced new buildbot failures, as reported here.
I was able to reproduce the failures with:
The root cause appears to be the static events counters used in the tests, when running the tests with repetitions (using the same interpreter state), the counts from the first test run affected the next runs.
This fixes it by resetting the counts when adding and clearing test watchers.