FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-91054: Reset static events counts in code watchers tests by itamaro · Pull Request #99978 · python/cpython · GitHub

/ cpython Public

GH-91054: Reset static events counts in code watchers tests #99978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Dec 4, 2022
+12 −3
Conversation 4 Commits 1 Checks 0 Files changed 2
Merged

GH-91054: Reset static events counts in code watchers tests #99978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) .py  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
6 changes: 3 additions & 3 deletions Lib/test/test_capi/test_watchers.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,11 @@ def test_code_object_events_dispatched(self):
del co3
self.assert_event_counts(2, 2, 1, 1)

# verify counts remain as they were after both watchers are cleared
# verify counts are reset and don't change after both watchers are cleared
co4 = _testcapi.code_newempty("test_watchers", "dummy4", 0)
self.assert_event_counts(2, 2, 1, 1)
self.assert_event_counts(0, 0, 0, 0)
del co4
self.assert_event_counts(2, 2, 1, 1)
self.assert_event_counts(0, 0, 0, 0)

def test_clear_out_of_range_watcher_id(self):
with self.assertRaisesRegex(ValueError, r"Invalid code watcher ID -1"):
Expand Down
9 changes: 9 additions & 0 deletions Modules/_testcapi/watchers.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,13 @@ add_code_watcher(PyObject *self, PyObject *which_watcher)
long which_l = PyLong_AsLong(which_watcher);
if (which_l == 0) {
watcher_id = PyCode_AddWatcher(first_code_object_callback);
num_code_object_created_events[0] = 0;
num_code_object_destroyed_events[0] = 0;
}
else if (which_l == 1) {
watcher_id = PyCode_AddWatcher(second_code_object_callback);
num_code_object_created_events[1] = 0;
num_code_object_destroyed_events[1] = 0;
}
else {
return NULL;
Expand All @@ -346,6 +350,11 @@ clear_code_watcher(PyObject *self, PyObject *watcher_id)
if (PyCode_ClearWatcher(watcher_id_l) < 0) {
return NULL;
}
// reset static events counters
if (watcher_id_l >= 0 && watcher_id_l < NUM_CODE_WATCHERS) {
num_code_object_created_events[watcher_id_l] = 0;
num_code_object_destroyed_events[watcher_id_l] = 0;
}
Py_RETURN_NONE;
}

Expand Down
Back | FazBrowse Home | New Git URL