Repository navigation
stubtest: use VERSIONS for submodules - #12083
Merged
JukkaL merged 4 commits intoJan 27, 2022
Merged
JukkaL merged 4 commits into
JukkaL merged 4 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
added 3 commits
January 27, 2022 01:34
srittau
approved these changes
Jan 27, 2022
srittau
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, although a few thoughts on possible future refactorings: It would make sense to share the version checking code between mypy and stubtest. Maybe get_typeshed_stdlib_modules() could return a simple class that provides an exists_in_version(module, version_info) method.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12062
Addresses feedback in #12066