FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adds `bdist_wininst` definition by sobolevn · Pull Request #7249 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Adds bdist_wininst definition - #7249

Merged
JelleZijlstra merged 14 commits into
python:masterfrom
sobolevn:add-bdist_wininst
Feb 21, 2022
ConversationCommits (14)ChecksFiles changed
Merged

Adds bdist_wininst definition#7249
JelleZijlstra merged 14 commits into
python:masterfrom
sobolevn:add-bdist_wininst

Conversation

sobolevn commented Feb 17, 2022

Copy link
Copy Markdown
Member

sobolevn commented Feb 17, 2022
View reviewed changes
Comment thread stdlib/@python2/distutils/config.pyi
boolean_options: ClassVar[list[str]]
def initialize_options(self) -> None: ...
def finalize_options(self) -> None: ...
@abstractmethod

sobolevn Feb 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've also removed several redefinitions of run abstract method. It is defined in Command

srittau reviewed Feb 17, 2022
View reviewed changes
Comment thread stdlib/distutils/command/bdist_wininst.pyi Outdated
from _typeshed import StrOrBytesPath
from typing import Any, ClassVar

if sys.version_info < (3, 10):

srittau Feb 17, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Instead of using this guard, the file should be added to VERSIONS.

sobolevn Feb 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is already there:

typeshed/stdlib/VERSIONS

Line 116 in 5c309e5

distutils.command.bdist_wininst: 2.7-3.9

sobolevn Feb 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See my comments below 🙂

hauntsaninja Feb 17, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure I see the comments you're referring to, but cf python/mypy#12083

sobolevn Feb 17, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

#7249 (comment)

This comment has been minimized.

Sign in to view
1 similar comment

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
1 similar comment

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

sobolevn commented Feb 17, 2022

Copy link
Copy Markdown
Member Author

Ok, looks like this commit finally passes: ebca810

I pushed one more to test things without if sys.version_info: d2506c8

sobolevn commented Feb 17, 2022

Copy link
Copy Markdown
Member Author

Yes, it failed 🎉

This comment has been minimized.

Sign in to view
2 similar comments

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

JelleZijlstra commented Feb 20, 2022

Copy link
Copy Markdown
Member

We now run stubtest from mypy master with the VERSIONS fix, could you merge master and try removing the version check again?

This comment has been minimized.

Sign in to view
1 similar comment

github-actions Bot commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

sobolevn commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

Done!

JelleZijlstra merged commit 4d169ea into python:master Feb 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau left review comments
hauntsaninja hauntsaninja left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL