Repository navigation
Use --warn-unreachable and --strict-equality in more tests - #20707
Merged
hauntsaninja merged 2 commits intoJan 31, 2026
Merged
hauntsaninja merged 2 commits into
hauntsaninja merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jan 31, 2026
Closed
hauntsaninja
added a commit
that referenced
this pull request
Feb 3, 2026
Less trivial follow up to #20707 Several of the skipped match tests now pass or have better behaviour, so unskipping them The two new tests I added both do not have great behaviour, mostly predating my rewrite. I improve these in #20660 but that PR is a little tricky to land, so I'm separating it out. This way it is easier for reviewers to evaluate what the changes are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure most tests in check-narrowing have both of these
Make sure most tests in check-isinstance have warn unreachable
Add to several tests in check-python310