Repository navigation
More testing related improvements and updates - #20709
Merged
hauntsaninja merged 2 commits intoFeb 3, 2026
Merged
hauntsaninja merged 2 commits into
hauntsaninja merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Closed
JukkaL
approved these changes
Feb 2, 2026
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Can you add comments to test cases where the behavior is still not ideal?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Added test comments, but even better is I have the fixes in #20660 so you will be able to see the correct diff soon :-) |
Sorry, something went wrong.
hauntsaninja
force-pushed
the
moretest
branch
from
d52a95d to
2bc9c93
Compare
February 3, 2026 04:29
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Feb 3, 2026
I added tests for this change in python#20709 so it's easier to see the diff. Like a few others, this was factored out of python#20660 to make that one easier to land. The change in bytes narrowing is also desirable (but unfortunately only applies with --no-strict-bytes). We can figure out something else for that case
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Feb 3, 2026
I added tests for this change in python#20709 so it's easier to see the diff. Like a few others, this was factored out of python#20660 to make that one easier to land. The change in bytes narrowing is also desirable (but unfortunately only applies with --no-strict-bytes). We can figure out something else for that case
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Feb 6, 2026
I added tests for this change in python#20709 so it's easier to see the diff. Like a few others, this was factored out of python#20660 to make that one easier to land. The change in bytes narrowing is also desirable (but unfortunately only applies with --no-strict-bytes). We can figure out something else for that case
hauntsaninja
added a commit
that referenced
this pull request
Feb 7, 2026
I added tests for this change in #20709 so it's easier to see the diff. Like a few others, this was factored out of #20660 to make that one easier to land. The change in bytes narrowing is also desirable (but unfortunately only applies with --no-strict-bytes). We can figure out something else for that case, as discussed in #20704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less trivial follow up to #20707
Several of the skipped match tests now pass or have better behaviour, so unskipping them
The two new tests I added both do not have great behaviour, mostly predating my rewrite. I improve these in #20660 but that PR is a little tricky to land, so I'm separating it out. This way it is easier for reviewers to evaluate what the changes are.