Repository navigation
Improve narrowing with numeric types - #20727
Merged
hauntsaninja merged 1 commit intoFeb 7, 2026
Merged
hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Closed
This comment has been minimized.
hauntsaninja
force-pushed
the
narrow80
branch
from
a957403 to
b310848
Compare
February 3, 2026 07:22
This comment has been minimized.
hauntsaninja
marked this pull request as draft
February 3, 2026 07:51
hauntsaninja
force-pushed
the
narrow80
branch
from
b310848 to
8dca9a2
Compare
February 3, 2026 08:34
Copy link
Copy Markdown
Collaborator
Author
|
The primer diff + the tests will be fixed by #20728 |
Sorry, something went wrong.
This comment has been minimized.
hauntsaninja
added a commit
that referenced
this pull request
Feb 6, 2026
I added tests for this change in python#20709 so it's easier to see the diff. Like a few others, this was factored out of python#20660 to make that one easier to land. The change in bytes narrowing is also desirable (but unfortunately only applies with --no-strict-bytes). We can figure out something else for that case
hauntsaninja
force-pushed
the
narrow80
branch
from
8dca9a2 to
4ac3457
Compare
February 6, 2026 21:38
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
hauntsaninja
marked this pull request as ready for review
February 6, 2026 21:59
Copy link
Copy Markdown
Collaborator
Author
|
Several of the problems here are pre-existing, so not a release blocker, but would be very good to have |
Sorry, something went wrong.
ilevkivskyi
approved these changes
Feb 7, 2026
ilevkivskyi
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LG, thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added tests for this change in #20709 so it's easier to see the diff. Like a few others, this was factored out of #20660 to make that one easier to land.
The change in bytes narrowing is also desirable (but unfortunately only applies with --no-strict-bytes). We can figure out something else for that case, as discussed in #20704