Repository navigation
Fix descriptor __get__/__set__ access on named tuple attributes - #22213
Open
VedantBhayani wants to merge 1 commit into
Open
VedantBhayani wants to merge 1 commit into
VedantBhayani wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Named tuples are represented as TupleType, but analyze_descriptor_access() returned early for any non-Instance type, so a __get__ or __set__ override defined on a named tuple class was ignored when the named tuple was used as a class attribute descriptor. Map TupleType to its fallback instance before the Instance check, matching what regular member access already does. Fixes python#22193.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named tuples are represented as TupleType, but analyze_descriptor_access() returned early for any non-Instance type. As a result, a __get__ (or __set__) override defined in a NamedTuple class body was ignored when the named tuple was used as a class attribute descriptor: reveal_type(SomeClass.tuple_descr) produced the raw tuple fallback instead of the __get__ return type.
Map TupleType to its fallback instance before the Instance check, matching how regular tuple member access already handles this via tuple_fallback().
Adds testDescriptorGetNamedTuple and testDescriptorSetNamedTuple regression tests covering both the class-attribute and instance-attribute access paths.
Fixes #22193.
Local test runs:
Note: this contribution was developed with LLM assistance under human review.