FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix descriptor __get__/__set__ access on named tuple attributes by VedantBhayani · Pull Request #22213 · python/mypy · GitHub

Repository navigation

Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .py  (1) .test  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 5 additions & 0 deletions mypy/checkmember.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,11 @@ def analyze_descriptor_access(descriptor_type: Type, mx: MemberContext) -> Type:
return make_simplified_union(
[analyze_descriptor_access(typ, mx) for typ in descriptor_type.items]
)
elif isinstance(descriptor_type, TupleType):
# Named tuples (and other tuple subclasses) are represented as TupleType.
# As with regular member access, use the fallback instance to look up
# descriptor methods such as __get__ and __set__.
descriptor_type = tuple_fallback(descriptor_type)
elif not isinstance(descriptor_type, Instance):
return orig_descriptor_type

Expand Down
39 changes: 39 additions & 0 deletions test-data/unit/check-classes.test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -2262,6 +2262,45 @@ def foo(x: Type[Union[X1, X2]]) -> None:
reveal_type(x.prop) # N: Revealed type is "__main__.getter"


[case testDescriptorGetNamedTuple]
from typing import Any, NamedTuple

class D(NamedTuple):
def __get__(self, instance: Any, owner: Any) -> str: return 's'

class A:
f = D()

reveal_type(A.f) # N: Revealed type is "builtins.str"
reveal_type(A().f) # N: Revealed type is "builtins.str"

class P(NamedTuple):
x: int

class B:
p = P(1)

reveal_type(B.p) # N: Revealed type is "tuple[builtins.int, fallback=__main__.P]"
reveal_type(B().p) # N: Revealed type is "tuple[builtins.int, fallback=__main__.P]"
[builtins fixtures/tuple.pyi]

[case testDescriptorSetNamedTuple]
from typing import Any, NamedTuple

class D(NamedTuple):
def __get__(self, instance: Any, owner: Any) -> str: return 's'
def __set__(self, instance: Any, value: int) -> None: pass

class A:
f = D()

a = A()
a.f = 1
reveal_type(a.f) # N: Revealed type is "builtins.str"
a.f = 'x' # E: Incompatible types in assignment (expression has type "str", variable has type "int")
[builtins fixtures/tuple.pyi]


-- _promote decorators
-- -------------------

Expand Down
Loading

Back | FazBrowse Home | New Git URL