FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Topic for release schedule PEPs by JelleZijlstra · Pull Request #2669 · python/peps · GitHub

/ peps Public

Add Topic for release schedule PEPs - #2669

Merged
JelleZijlstra merged 11 commits into
python:mainfrom
JelleZijlstra:topicrelease
Oct 7, 2022
ConversationCommits (11)ChecksFiles changed
Merged

Add Topic for release schedule PEPs#2669
JelleZijlstra merged 11 commits into
python:mainfrom
JelleZijlstra:topicrelease

Conversation

JelleZijlstra commented Jun 25, 2022

Copy link
Copy Markdown
Member

Release PEPs are a pretty unusual kind of PEP and it's useful to me to have
them all listed together. Happy to adjust the name of the topic if desired.

I took the opportunity to adjust the status of a few release PEPs. Now all
releases for EOL versions are Final (3.5 was previously Active), and all
releases for released versions are Active (3.10 was still draft). 3.11 remains
Draft as 3.11 has not yet been released.

Add Topic for release schedule PEPs
1184100 
Release PEPs are a pretty unusual kind of PEP and it's useful to me to have
them all listed together. Happy to adjust the name of the topic if desired.

I took the opportunity to adjust the status of a few release PEPs. Now all
releases for EOL versions are Final (3.5 was previously Active), and all
releases for released versions are Active (3.10 was still draft). 3.11 remains
Draft as 3.11 has not yet been released.
CAM-Gerlach reviewed Jun 25, 2022
View reviewed changes
Comment thread .pre-commit-config.yaml Outdated

hugovk commented Jun 25, 2022

Copy link
Copy Markdown
Member

This would be useful.

Preview: https://pep-previews--2669.org.readthedocs.build/topic/releases/

Please also include PEP 693 for Python 3.12.

AA-Turner commented Jun 25, 2022

Copy link
Copy Markdown
Member

Happy to adjust the name of the topic if desired.

"Release Schedule" would make sense to me, spaces are allowed within the topic names.

A

AA-Turner reviewed Jun 25, 2022
View reviewed changes

AA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please also add PEP-160, PEP-200, PEP-226, PEP-251, PEP-283, PEP-320, and PEP-356

A

Comment thread pep_sphinx_extensions/pep_zero_generator/constants.py Outdated
Comment thread pep_sphinx_extensions/pep_zero_generator/constants.py Outdated
Comment thread pep_sphinx_extensions/pep_zero_generator/constants.py Outdated

CAM-Gerlach commented Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

"Release Schedule" would make sense to me, spaces are allowed within the topic names.

But then the URL to the topic page wouldn't match the lowercase/case insensitive topic name; either it would have to have _, - inserted or escape codes inserted, and the same for the generated rst file name. It's also extra words, and the "Releases" PEP isn't just a schedule, it also lists the features of the release, crew, and other details.

pradyunsg commented Jun 27, 2022

Copy link
Copy Markdown
Member

My 2 cents: "Release Schedule" or "Release" are better names since they'll read better in the page heading ("Release Schedule PEPs"/"Release PEPs"). Right now, it looks to me like there's a grammatical error in there.

pradyunsg commented Jun 27, 2022

Copy link
Copy Markdown
Member

It might also make sense to retitle "Other Informational PEPs" to "Informational PEPs" on all pages, since having an "Other" in the first heading seems wrong (as is the case with this topic index right now).

CAM-Gerlach commented Jun 28, 2022

Copy link
Copy Markdown
Member

My 2 cents: "Release Schedule" or "Release" are better names since they'll read better in the page heading ("Release Schedule PEPs"/"Release PEPs"). Right now, it looks to me like there's a grammatical error in there.

👍 to "Release"

JelleZijlstra commented Jul 1, 2022

Copy link
Copy Markdown
Member Author

The latest pushes add the PEPs I missed (thanks Adam for digging those up!), address other feedback, and rename the header to "Release".

CAM-Gerlach reviewed Jul 2, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry I didn't mention it before, but like on #2670 , I suggest using a consistant header order with the existing packaging-topic PEPs, i.e. Topic after Type.

Comment thread pep-0160.txt Outdated
Comment thread pep_sphinx_extensions/pep_zero_generator/constants.py Outdated
CAM-Gerlach approved these changes Oct 7, 2022
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks @JelleZijlstra

JelleZijlstra marked this pull request as ready for review October 7, 2022 01:01
JelleZijlstra merged commit e46b836 into python:main Oct 7, 2022
JelleZijlstra deleted the topicrelease branch October 7, 2022 01:01
hugovk mentioned this pull request Jan 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AA-Turner AA-Turner left review comments
hugovk hugovk approved these changes
CAM-Gerlach CAM-Gerlach approved these changes
Yhg1s Awaiting requested review from Yhg1s
pablogsal Awaiting requested review from pablogsal
ambv Awaiting requested review from ambv
ned-deily Awaiting requested review from ned-deily
larryhastings Awaiting requested review from larryhastings
birkenfeld Awaiting requested review from birkenfeld
benjaminp Awaiting requested review from benjaminp
warsaw Awaiting requested review from warsaw
gvanrossum Awaiting requested review from gvanrossum
rhettinger Awaiting requested review from rhettinger
jeremyhylton Awaiting requested review from jeremyhylton
freddrake Awaiting requested review from freddrake

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL