FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PEP 404: Add Python 2.8 to Release PEPs topic by hugovk · Pull Request #2986 · python/peps · GitHub

/ peps Public

PEP 404: Add Python 2.8 to Release PEPs topic - #2986

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:add-2.8-to-release-topic
Jan 31, 2023
ConversationCommits (1)ChecksFiles changed
Merged

PEP 404: Add Python 2.8 to Release PEPs topic#2986
hugovk merged 1 commit into
python:mainfrom
hugovk:add-2.8-to-release-topic

Conversation

hugovk commented Jan 30, 2023

Copy link
Copy Markdown
Member

Follow on to #2669.

Add PEP 404 ("Python 2.8 Un-release Schedule") to the Release topic.

It's an un-release schedule for a 404 version-not-found :) but probably belongs in the topic.

warsaw approved these changes Jan 30, 2023
View reviewed changes

warsaw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved, with questions: should info collection include a test on Topic? I haven't been following the addition of this header, and can't check atm, but has this header been added to PEP 101?

hugovk commented Jan 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Approved, with questions: should info collection include a test on Topic?

If I understand the question properly: no, there are lots of informational PEPs, and only a small handful are in any topics.

I haven't been following the addition of this header, and can't check atm, but has this header been added to PEP 101?

It hasn't. (This "Release" topic was added in #2669, and support for topic headers was added in #2579.)

I don't think it needs to be in the release checklist, as it's something to check when the new release PEP is created, not an actual release.

Plus I expect release managers will copy/paste the last release PEP for the next one.

warsaw commented Jan 30, 2023

Copy link
Copy Markdown
Member

has this header been added to PEP 101

Oops! I meant PEP 1! I think Topic should be added to PEP 1 and PEP 12.

CAM-Gerlach approved these changes Jan 31, 2023
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks @hugovk !

hugovk commented Jan 31, 2023

Copy link
Copy Markdown
Member Author

has this header been added to PEP 101

Oops! I meant PEP 1! I think Topic should be added to PEP 1 and PEP 12.

Good idea, I'll open another PR for that :)

hugovk merged commit 77bbe79 into python:main Jan 31, 2023
hugovk deleted the add-2.8-to-release-topic branch January 31, 2023 09:03
hugovk mentioned this pull request Jan 31, 2023
Merged

hugovk commented Jan 31, 2023

Copy link
Copy Markdown
Member Author

Please see PR #2995 to document the Topic header in PEPs 1 and 12.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

warsaw warsaw approved these changes
CAM-Gerlach CAM-Gerlach approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL