FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Infra: Automatically edit PRs with link to RTD preview by hugovk · Pull Request #3031 · python/peps · GitHub

/ peps Public

Infra: Automatically edit PRs with link to RTD preview - #3031

Merged
hugovk merged 1 commit into
python:mainfrom
hugovk:rtd-pr-preview
Mar 1, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Infra: Automatically edit PRs with link to RTD preview#3031
hugovk merged 1 commit into
python:mainfrom
hugovk:rtd-pr-preview

Conversation

hugovk commented Feb 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Once merged, this will automatically add a docs preview link to PRs.

GitHub Action that automatically edits Pull Requests' descriptions with a link to documentation's preview on Read the Docs.

https://github.com/readthedocs/actions/tree/v1/preview

For example: python/docs-community#75

hugovk added the infra Core infrastructure for building and rendering PEPs label Feb 28, 2023
CAM-Gerlach approved these changes Mar 1, 2023
View reviewed changes

CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks @hugovk ! Very useful improvement, especially after the recent UX-unfriendly changes for accessing them from the Details link in the checks list.

CAM-Gerlach commented Mar 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Maybe we could also adapt the action ourselves (as I don't see a currently published equivalent) to do the same thing for Netlify, for use on CPython? Not sure how hard that would be...

hugovk merged commit d54d4e6 into python:main Mar 1, 2023
hugovk deleted the rtd-pr-preview branch March 1, 2023 11:52

hugovk commented Mar 1, 2023

Copy link
Copy Markdown
Member Author

Here's a demo:

And we'll probably need to add single-version: "true" here in PEPs so we get https://pep-previews--3018.org.readthedocs.build/ instead of https://pep-previews--3018.org.readthedocs.build/en/3018. Will wait for the next incoming PR to confirm.

CAM-Gerlach commented Mar 2, 2023

Copy link
Copy Markdown
Member

Wow, you're consistently amazing @hugovk ! Fantastic stuff! I'll keep on the lookout for another PR...

hugovk mentioned this pull request Mar 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
CAM-Gerlach CAM-Gerlach approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

infra Core infrastructure for building and rendering PEPs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL