Infra: RTD preview links should be single version - #3035
Merged
CAM-Gerlach merged 1 commit intoMar 3, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
CAM-Gerlach
approved these changes
Mar 3, 2023
CAM-Gerlach
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks @hugovk . Since this needs to be merged to see the change and is affecting PRs in production, I'll go ahead and merge this now.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@hugovk would be great to add this to the devguide too, no? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on from #3031.
See for example #3034: it links to https://pep-previews--3034.org.readthedocs.build/en/3034/ (404) but should like to https://pep-previews--3034.org.readthedocs.build/ because we build Read the Docs as a "single version" with no language or other versions.
Docs: https://github.com/readthedocs/actions/tree/v1/preview#configuration
Likely needs merging to take effect.
📚 Documentation preview 📚: https://pep-previews--3035.org.readthedocs.build/en/3035/