I reviewed the pre-commit guidance---it seems that our usages of types: were mostly redundant due to filtering files to match PEPs, so I've just removed them.

A

Out of a slight fear of this going the same way as #2672, please may I ask if anyone has any burning passions against the general proposal to move the PEPs into a sub-folder? (We can tweak implementation details later, of course.)

If all is well, I'd like to set a timeline for merging this -- perhaps Tuesday or Wednesday, if that's not too early?

A

No burning passions, no. Just a broad "is this worth the effort", but I'm not going to stand in anyone's way.

I'll merge this today, sorry in advance for the review-request spam.

A

I'll keep an eye on https://peps.python.org just in case.

All seems well!

A

@Jose1654 'approving' merged pull requests spams a large number of people and is otherwise useless. Please do not repeat.

@Jose1654 'approving' merged pull requests spams a large number of people and is otherwise useless. Please do not repeat.

I already reported the user to GitHub for spamming. Are we able to disallow reviews from non-members? This keeps happening, every once in a while.

We can disallow reviews that approve/request changes for those without explicit read access, but not cannot disallow comment reviews.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-pull-request-reviews-in-your-repository

Do we get useful approve/request-change reviews from real non-members?

We often have external co-authors. They can add a comment instead, but is that ok?

I would oppose changing this configuration because of the occasional random user doing something annoying. Just ignore them.

Users outside the Python org can and do leave useful reviews, especially on this repo.

Yeah, that's fair. It'd be nice to be able to disallow drive-bys from people who have had no other interaction AND who don't leave any comments in the review, but that's a bit too sophisticated to ask for.