PEP 1 and 12: Remove optional Content-Type from templates - #3454
Merged
AA-Turner merged 1 commit intoSep 28, 2023
Merged
AA-Turner merged 1 commit into
AA-Turner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
requested review from
CAM-Gerlach,
brettcannon,
ncoghlan and
warsaw
as code owners
September 27, 2023 21:08
warsaw
approved these changes
Sep 27, 2023
pradyunsg
approved these changes
Sep 27, 2023
brettcannon
approved these changes
Sep 27, 2023
AA-Turner
approved these changes
Sep 28, 2023
AA-Turner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
As it happens I have a draft branch that removes Content-Type from all PEPs. But I thought likely too disruptive given the spate of recent changes; this is a nice compromise. Thanks!
A
Sorry, something went wrong.
13 tasks done
This was referenced Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2500.
There are three 👍s on Is Content-Type optional? #2500 (comment), for removing the optional Content-Type header from the PEP 1 and 12 templates: @JelleZijlstra, @encukou, @hugovk, @CAM-Gerlach.
@AA-Turner was -0 in Is Content-Type optional? #2500 (comment)
But following issue #10 / PR #3418, all PEPs now have an .rst extension, so we no longer need the optional header for new PEPs.
📚 Documentation preview 📚: https://pep-previews--3454.org.readthedocs.build/