FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Previews in pull requests by hugovk · Pull Request #105 · python/python-docs-theme · GitHub

Repository navigation

Previews in pull requests - #105

Merged
pradyunsg merged 3 commits into
python:mainfrom
hugovk:rtd-preview
Feb 13, 2023
Merged

pradyunsg merged 3 commits into
python:mainfrom
hugovk:rtd-preview

Conversation

hugovk commented Jan 31, 2023 •
edited by pradyunsg
Loading

Copy link
Copy Markdown
Member

Fixes #70.

#70 suggested Read the Docs and Netlify, but we have a bit of a bus factor problem with Netlify on the CPython docs due to only having a single account that can access the admin, so let's use Read the Docs as well. We're using it successfully in the PEPs repo.

Here's a demo build:

Draft because:

And we need to set up Read the Docs:

hugovk mentioned this pull request Jan 31, 2023

hugovk commented Feb 6, 2023

Copy link
Copy Markdown
Member Author

Ping @Mariatta

JDLH commented Feb 6, 2023

Copy link
Copy Markdown

I wasn't aware of the term "bus factor". For the information of others like me, it refers to a risk that critical roles in a project are limited to a small number of people, in the sense of "in case they get hit by a bus". There is a nice Wikipedia article, Bus factor.

hugovk changed the title Build CPython docs on Read the Docs Previews in pull requests Feb 6, 2023

Mariatta commented Feb 6, 2023

Copy link
Copy Markdown
Member

Project created: https://readthedocs.org/projects/python-docs-theme-previews/

Who else should I add as maintainers?

hugovk commented Feb 6, 2023

Copy link
Copy Markdown
Member Author

Thanks! Maybe @JulienPalard, @ezio-melotti and me?

Copy link
Copy Markdown
Member

I'd be happy to be listed as well, if we don't have enough people. :)

Mariatta commented Feb 6, 2023

Copy link
Copy Markdown
Member

I'll need your readthedocs usernames: @hugovk, @pradyunsg, @JulienPalard, @ezio-melotti

Copy link
Copy Markdown
Member

I'm pradyunsg (perhaps, unsurprisingly).

hugovk commented Feb 6, 2023

Copy link
Copy Markdown
Member Author

I'm hugovk (perhaps, unsurprisingly).

Mariatta commented Feb 6, 2023

Copy link
Copy Markdown
Member

Invites sent.

hugovk commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

I'll close this and re-open it as a new PR, and hopefully it will trigger an RTD build 🤞

hugovk closed this Feb 7, 2023
hugovk mentioned this pull request Feb 7, 2023

hugovk commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

Nope, didn't trigger for #107, re-opening this.

It worked on my fork, I'll compare settings:

hugovk reopened this Feb 7, 2023

hugovk commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

OK, so the incoming GitHub webhook is good on my fork (at https://readthedocs.org/dashboard/hugovk-python-docs-theme/integrations/225260/):

Details

And I also see a webhook (at https://github.com/hugovk/python-docs-theme/settings/hooks):

Details

But not for this repo (at https://readthedocs.org/dashboard/python-docs-theme-previews/integrations/225787/):

Details

If I click "Resync webhook" I get "Webhook activation failed. Make sure you have the necessary permissions", which makes sense as I don't have admin permissions here.


@Mariatta Please can you try the "Resync webhook" button at https://readthedocs.org/dashboard/python-docs-theme-previews/integrations/225787/?

And is there anything at https://github.com/python/python-docs-theme/settings/hooks?

hugovk commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

Łukasz has enabled we hooks. 🎣

Close/re-open to retrigger...

hugovk closed this Feb 7, 2023
hugovk reopened this Feb 7, 2023
hugovk marked this pull request as ready for review February 7, 2023 21:37

hugovk commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

Deploy preview is now built!

Ready for review!

https://python-docs-theme-previews--105.org.readthedocs.build/en/105/

pradyunsg merged commit 506e0f2 into python:main Feb 13, 2023
hugovk deleted the rtd-preview branch February 13, 2023 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Previews in pull requests

4 participants


Back | FazBrowse Home | New Git URL