Reduce footer margin only for desktop - #106
Merged
hugovk merged 1 commit intoFeb 16, 2023
Merged
hugovk merged 1 commit into
hugovk merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Rebased on main to check the RTD deploy preview (#70 / #105)... success! ✅ https://python-docs-theme-previews--106.org.readthedocs.build/en/106/ |
Sorry, something went wrong.
Comment thread
python_docs_theme/static/pydoctheme.css
| } | ||
| } | ||
|
|
||
| @media (min-width: 1024px) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Have you tested this in landscape mode (assuming that's supported)?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Here's a narrow landscape mode (iPhone SE):
And a wide landscape mode (iPad Air):
Sorry, something went wrong.
pradyunsg
approved these changes
Feb 13, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
The margin above the footer is currently reduced by 2em.
Desktop
This makes sense for desktop widths (1024+ pixels). With the reduction:
ScreenshotIf it was removed for desktop there's a bigger gap between the "Quick search" box and the copyright line:
ScreenshotMobile
But on mobile (< 1024 pixels), it hides the copyright line:
ScreenshotSo let's remove this margin only for desktops:
ScreenshotDemo build
https://hugovk-python-docs-theme.readthedocs.io/en/fix-footer-demo/