FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Reduce underline offset by hugovk · Pull Request #166 · python/python-docs-theme · GitHub

Repository navigation

Reduce underline offset - #166

Merged
pradyunsg merged 2 commits into
python:mainfrom
hugovk:text-underline-offset
Jan 27, 2024
Merged

pradyunsg merged 2 commits into
python:mainfrom
hugovk:text-underline-offset

Conversation

hugovk commented Jan 27, 2024

Copy link
Copy Markdown
Member

We added underlines in #160, with an offset to make sure they don't obscure underscores in code formatting. With fresh eyes, 0.3em looks a bit too much. Let's reduce it.

0.3em

0.2em

ezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Have you tried checking this on a paragraph with lot of dunders?

ISTM that with 0.2em the underline touches the underscores.
Maybe 0.25em would be a good comprise?

hugovk commented Jan 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Here's a link to the build preview of that section:

https://python-docs-theme-previews--166.org.readthedocs.build/en/166/reference/datamodel.html#object.reversed

There is a small gap between the underscore and underline (Android/Chrome):

hugovk commented Jan 27, 2024

Copy link
Copy Markdown
Member Author

macOS / Chrome:

0.2em

0.21em

0.22em

0.23em

0.24em

0.25em

Copy link
Copy Markdown
Member

This is on Linux/Firefox:
0.2em:

0.25em:

0.3em:

I like 0.25 -- with 0.2 I have to do a double take because I'm not sure if there are two lines or I'm seeing double; with 0.3 the difference is clear, but it does look a bit too distant (especially when there are no underscores); with 0.25 the underline is closer to the text but I can still see the two lines distinctly. (Disclaimer, I'm running on 4h of sleep and my eyes are a bit tired, I can take a look again tomorrow -- maybe the 0.2 will look better).

hugovk commented Jan 27, 2024

Copy link
Copy Markdown
Member Author

0.25em looks okay to me, PR updated.

pradyunsg merged commit ba55891 into python:main Jan 27, 2024
hugovk deleted the text-underline-offset branch January 27, 2024 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL