Only apply underline offset to code formatting for underline visibility - #171
Merged
hugovk merged 6 commits intoFeb 4, 2024
Merged
hugovk merged 6 commits into
hugovk merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ezio-melotti
approved these changes
Feb 4, 2024
ezio-melotti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I would add a comment explaining what these two rules do, otherwise LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #168.
In #160 we added underlines to links, with an extra offset to help make sure underscores (_) are not obscured by the underlines.
(In #166 we reduced the amount of offset.)
We only really need the offset for code formatting, where underscores often show up, so we can use the default offset for normal links and only apply an extra offset for code.