FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Horizontally align the collapse button icon by tomasr8 · Pull Request #219 · python/python-docs-theme · GitHub

  1. python
  2. python-docs-theme

Repository navigation

Horizontally align the collapse button icon - #219

Merged
AA-Turner merged 1 commit into
python:mainfrom
tomasr8:center-collapse-btn
Feb 3, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Horizontally align the collapse button icon#219
AA-Turner merged 1 commit into
python:mainfrom
tomasr8:center-collapse-btn

Conversation

tomasr8 commented Feb 2, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Just something that was bugging me a bit :D I hope this won't be an issue regarding 4.x compatibility?

Before

After

📚 Documentation preview 📚: https://python-docs-theme-previews--219.org.readthedocs.build/

m-aciek commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

Wulian233 reviewed Feb 2, 2025
View reviewed changes
Comment thread python_docs_theme/static/pydoctheme.css
border-left: none;
}

#sidebarbutton span {

Wulian233 Feb 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we achieve compatibility without deleting this?

AA-Turner commented Feb 2, 2025

Copy link
Copy Markdown
Member

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

Note I'm proposing pinning python-docs-theme for the 3.10 and 3.11 branches in python/cpython#129576. We already pinned for the 3.8 and 3.9 branches in python/cpython#115349. However in the absence of that, this PR should be tested with 3.4.3, 7.2.6, and 8.1.3 ([ref]).

A

tomasr8 commented Feb 2, 2025

Copy link
Copy Markdown
Member Author

I'll test it later today or tomorrow (at Fosdem currently)

tomasr8 commented Feb 3, 2025

Copy link
Copy Markdown
Member Author

In addition to 8.1.3, I checked with 3.4.3 and 7.2.6 and both work as well :)

AA-Turner merged commit 2f15ba6 into python:main Feb 3, 2025
This was referenced Feb 3, 2025
Merged
Merged
tomasr8 deleted the center-collapse-btn branch February 3, 2025 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
+1 more reviewer
Wulian233 Wulian233 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL