Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
srittau
approved these changes
Sep 27, 2023
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM, but one optional nit.
Sorry, something went wrong.
Comment thread
stdlib/tty.pyi
Outdated
| def setcbreak(fd: _FD, when: int = 2) -> None: ... | ||
|
|
||
| if sys.version_info >= (3, 12): | ||
| __all__ += ["cfmakeraw", "cfmakecbreak"] |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Nit: My quick random sampling shows me that we usually move these __all__ += constructs to the top of the file, even if it means a duplicated version/platform check. Personally, I find this better too, since you can easier spot the contents of __all__ for all branches.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: https://github.com/python/cpython/blob/3.12/Lib/tty.py