[tty] py312: Fix return types of set(raw|cbreak) - #10785
Merged
JelleZijlstra merged 7 commits intoSep 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Also add `termios._AttrReturn` type alias to be used in tty
Copy link
Copy Markdown
Collaborator
Author
|
Waiting for #10784 due to conflicts. |
Sorry, something went wrong.
AlexWaygood
reviewed
Sep 27, 2023
Comment thread
stdlib/termios.pyi
Outdated
This comment has been minimized.
sobolevn
reviewed
Sep 27, 2023
Comment thread
stdlib/tty.pyi
Outdated
srittau
marked this pull request as ready for review
September 27, 2023 09:29
Copy link
Copy Markdown
Collaborator
Author
|
@sobolevn I've also replaced _Mode with termio._Attr as I believe these represent the same thing? |
Sorry, something went wrong.
AlexWaygood
reviewed
Sep 27, 2023
Comment thread
stdlib/tty.pyi
Outdated
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Sep 28, 2023
Copy link
Copy Markdown
Member
|
Submitted python/cpython#110028 to document some of these changes better |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add termios._AttrReturn type alias to be used in tty