FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Set literal default arguments for `pickle.Pickler.__init__` and `pickle.Unpickler.__init__` by brianschubert · Pull Request #12797 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Set literal default arguments for pickle.Pickler.__init__ and pickle.Unpickler.__init__ - #12797

Merged
srittau merged 1 commit into
python:mainfrom
brianschubert:stdlib-pickle-pickler
Oct 13, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Set literal default arguments for pickle.Pickler.__init__ and pickle.Unpickler.__init__#12797
srittau merged 1 commit into
python:mainfrom
brianschubert:stdlib-pickle-pickler

Conversation

brianschubert commented Oct 13, 2024

Copy link
Copy Markdown
Collaborator

Similar default arguments were filled-in to other parts of pickle in #9501. For whatever reason, pickle.Pickler.__init__ and pickle.Unpickler.__init__ aren't picked up by stubdefaulter.

For reference:

>>> import inspect, pickle
>>> inspect.signature(pickle.Pickler)
<Signature (file, protocol=None, fix_imports=True, buffer_callback=None)>
>>> inspect.signature(pickle.Unpickler)
<Signature (file, *, fix_imports=True, encoding='ASCII', errors='strict', buffers=())>

github-actions Bot commented Oct 13, 2024

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau merged commit 01036d2 into python:main Oct 13, 2024
brianschubert mentioned this pull request Oct 13, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL