| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
To keep this PR manageable, I'm going to fix any issues in CI by just reverting the affected functions. Notes on CI:
|
Sorry, something went wrong.
|
We also got a pytype crash Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/pytype/pyi/visitor.py", line 36, in _call_visitor
return super()._call_visitor(node)
File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/pytype/ast/visitor.py", line 55, in _call_visitor
return visitor(node)
File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/pytype/pyi/parser.py", line [16](https://github.com/python/typeshed/actions/runs/3896137144/jobs/6652302058#step:7:17)2, in visit_Pyval
return self.convert_late_annotation(node.value)
File "/opt/hostedtoolcache/Python/3.10.9/x64/lib/python3.10/site-packages/pytype/pyi/parser.py", line 142, in convert_late_annotation
typ = a.body[0].value # pytype: disable=attribute-error
IndexError: list index out of range
I suspect like flake8-pyi it's something to do with treating string defaults as annotations but I'll have to look at the code. |
Sorry, something went wrong.
|
Just checking, you ran latest stubtest locally with the default checking you added? |
Sorry, something went wrong.
|
Not yet, I forgot it hadn't been released yet. |
Sorry, something went wrong.
|
We've often used pre-release stubtest in CI. Might be a good idea to do that now too! |
Sorry, something went wrong.
|
For reference fdc5863 is where we undid stubtest-from-master most recently, but some of the infra has changed since then so it's not just a matter of reverting and updating the commit. |
Sorry, something went wrong.
The runtime defaults are None. Found in python#9501.
The runtime defaults are None. Found in #9501.
See python/typeshed#9501. Resolves #1350 PiperOrigin-RevId: 501717379
See python/typeshed#9501. Resolves #1350 PiperOrigin-RevId: 501717379
|
New version with the latest stubdefaulter:
The PR currently doesn't include a change to the version of stubtest. If we want to run stubtest from mypy master, I'd rather do that in a separate PR. |
Sorry, something went wrong.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
There was a problem hiding this comment.
A quick glance shows no obvious problems. But I mostly rely on our tests here.
Sorry, something went wrong.
Continuing work towards #8988. The first five commits were created using stubdefaulter on various Python versions; the following commits were all created manually by me to fix various problems. The main things this adds that weren't present in #9501 are: - Defaults in Windows-only modules and Windows-only branches (because I'm running a Windows machine) - Defaults in non-py311 branches - Defaults for float parameters - Defaults for overloads
Continuing work towards python#8988. The first five commits were created using stubdefaulter on various Python versions; the following commits were all created manually by me to fix various problems. The main things this adds that weren't present in python#9501 are: - Defaults in Windows-only modules and Windows-only branches (because I'm running a Windows machine) - Defaults in non-py311 branches - Defaults for float parameters - Defaults for overloads
| Back | FazBrowse Home | New Git URL |
Ran https://github.com/JelleZijlstra/stubdefaulter on the stdlib