FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Python 3.14 stubs by JelleZijlstra · Pull Request #15717 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Update Python 3.14 stubs - #15717

Merged
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:codex/py314-whatsnew-stub-fixes
May 8, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Update Python 3.14 stubs#15717
JelleZijlstra merged 2 commits into
python:mainfrom
JelleZijlstra:codex/py314-whatsnew-stub-fixes

Conversation

JelleZijlstra commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • add Python 3.14 name support to tkinter.OptionMenu and tkinter.ttk.OptionMenu
  • add TypeAliasType.__iter__ for Python 3.14 star-unpacking support

srittau reviewed May 8, 2026
View reviewed changes
Comment thread stdlib/tkinter/__init__.pyi Outdated
@@ -3751,6 +3738,7 @@ class OptionMenu(Menubutton):
*values: str,
# kwarg only from now on

srittau May 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While we're here: Could we remove this comment? This seems fairly obvious if you know Python.

srittau reviewed May 8, 2026
View reviewed changes
Comment thread stdlib/tkinter/__init__.pyi Outdated
*values: str,
# kwarg only from now on
command: Callable[[StringVar], object] | None = ...,
name: str = ...,

srittau May 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
name: str = ...,
name: str | None = None,

srittau May 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But I just checked: Codex is correct that these were added in 3.14, so we need conditional branches here and in ttk.pyi.

JelleZijlstra May 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point, thanks for checking!

This comment has been minimized.

Sign in to view

JelleZijlstra commented May 8, 2026

Copy link
Copy Markdown
Member Author

For context I had Codex look at the Python 3.14 What's New too and look for missed changes. I made this draft for now so I could take another look before sending for review.

srittau reviewed May 8, 2026
View reviewed changes
Comment thread stdlib/tkinter/ttk.pyi Outdated
JelleZijlstra force-pushed the codex/py314-whatsnew-stub-fixes branch from d6684b2 to f39115e Compare May 8, 2026 13:12
JelleZijlstra marked this pull request as ready for review May 8, 2026 13:14
JelleZijlstra marked this pull request as draft May 8, 2026 13:15
JelleZijlstra marked this pull request as ready for review May 8, 2026 13:21
srittau approved these changes May 8, 2026
View reviewed changes

srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the over-eager review. :)

JelleZijlstra merged commit 2d78fda into python:main May 8, 2026
49 checks passed

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas)
- pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...")  [var-annotated]

JelleZijlstra mentioned this pull request May 8, 2026
Merged
JelleZijlstra deleted the codex/py314-whatsnew-stub-fixes branch May 8, 2026 13:52
JelleZijlstra added a commit that referenced this pull request May 8, 2026
tkinter: add **kwargs support to tkinter.Misc.after for 3.14 (#15720)
78a12c6 
In Python 3.14, python/cpython#126900 added kwargs support to `tkinter.Misc.after`.
stubtest missed this because we allowlist the function for a different reason.

Found by Codex along with #15717 (I didn't include it in that PR because I incorrectly convinced myself
this one was more complicated). It also found missing **kwargs support for some asyncio create_task functions,
but we already have issues/PRs about that (e.g. #13687).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL