tkinter: add **kwargs support to tkinter.Misc.after for 3.14 - #15720
Merged
JelleZijlstra merged 1 commit intoMay 8, 2026
Merged
JelleZijlstra merged 1 commit into
JelleZijlstra merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
In Python 3.14, python/cpython#126900 added kwargs support to `tkinter.Misc.after`. stubtest missed this because we allowlist the function for a different reason. Found by Codex along with python#15717 (I didn't include it in that PR because I incorrectly convinced myself this one was more complicated). It also found missing **kwargs support for some asyncio create_task functions, but we already have issues/PRs about that (e.g. python#13687).
srittau
approved these changes
May 8, 2026
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
This is not a bad instinct with tkinter. It is very dynamic, so type annotations for tkinter are usually surprisingly hard to get right. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3.14, python/cpython#126900 added kwargs support to tkinter.Misc.after.
stubtest missed this because we allowlist the function for a different reason.
Found by Codex along with #15717 (I didn't include it in that PR because I incorrectly convinced myself
this one was more complicated). It also found missing **kwargs support for some asyncio create_task functions,
but we already have issues/PRs about that (e.g. #13687).