Add a backport of generic NamedTuples - #44
Merged
JelleZijlstra merged 21 commits intoMay 26, 2022
Merged
JelleZijlstra merged 21 commits into
JelleZijlstra merged 21 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
AlexWaygood
marked this pull request as ready for review
May 20, 2022 19:48
AlexWaygood
commented
May 20, 2022
Comment thread
src/test_typing_extensions.py
Copy link
Copy Markdown
Member
Author
|
I think this is now ready for review! |
Sorry, something went wrong.
srittau
reviewed
May 21, 2022
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I don't really claim to know what's going in this code, but everything seems reasonable and makes sense to me, but I have a few small remarks.
Sorry, something went wrong.
Comment thread
README.md
Outdated
Comment thread
src/test_typing_extensions.py
Comment thread
src/typing_extensions.py
Outdated
Comment thread
src/typing_extensions.py
Outdated
srittau
approved these changes
May 21, 2022
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you! I have a few small comments.
Sorry, something went wrong.
Comment thread
README.md
Outdated
Comment thread
README.md
Outdated
Comment thread
src/test_typing_extensions.py
Comment thread
src/test_typing_extensions.py
Outdated
Comment thread
src/typing_extensions.py
Comment thread
src/typing_extensions.py
Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
AlexWaygood
commented
May 21, 2022
Comment thread
src/typing_extensions.py
Outdated
Comment thread
src/test_typing_extensions.py
Outdated
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
approved these changes
May 21, 2022
Copy link
Copy Markdown
Member
|
Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thank you! Super excited to see this happen :D |
Sorry, something went wrong.
This was referenced Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the ability, added in python/cpython#92027, to define generic NamedTuple classes. The implementation and the tests are very similar to the implementation on the CPython main branch, with a few tweaks so that it all works on earlier versions of Python as well.
#7