(fix): minimum python version 3.11 forNamedTuple with Generic - #1594
Merged
ilan-gold merged 1 commit intoAug 12, 2024
Merged
ilan-gold merged 1 commit into
ilan-gold merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #1594 +/- ##
==========================================
- Coverage 86.70% 84.21% -2.50%
==========================================
Files 37 37
Lines 5974 5974
==========================================
- Hits 5180 5031 -149
- Misses 794 943 +149
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was off on the version in my old comment: python/cpython#92027
In any case, we can just use typing_extensions: python/typing_extensions#44 but I don't think it's worth it so we'll just correct the feature version for the check.
Previously, this was causing issues with 3.10 as this was the case not covered (this feature broke in 3.9, but is fixed in 3.11, and we special cased <3.10).