Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 88.72549% with 23 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #1202 +/- ##
==========================================
+ Coverage 91.93% 92.05% +0.11%
==========================================
Files 27 27
Lines 4688 4680 -8
==========================================
- Hits 4310 4308 -2
+ Misses 378 372 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
akx
marked this pull request as ready for review
March 18, 2025 08:08
akx
force-pushed
the
reruff
branch
3 times, most recently
from
c0e3a27 to
a587a5b
Compare
March 19, 2025 11:05
akx
marked this pull request as draft
March 19, 2025 11:05
akx
force-pushed
the
reruff
branch
3 times, most recently
from
d026dca to
859ba8d
Compare
June 24, 2025 11:58
akx
marked this pull request as ready for review
June 24, 2025 12:02
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes code formatting in the babel/ directory using Ruff (line length set to 95) and manual # fmt: skip annotations, without altering functionality, and updates tooling configs.
- Set Ruff line-length to 95 to balance existing line widths and readability
- Reformatted all Babel modules for consistent multi-line arguments and trailing commas
- Bumped the Ruff hook version in .pre-commit-config.yaml
Reviewed Changes
Copilot reviewed 22 out of 26 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| pyproject.toml | Added line-length = 95 to the Ruff config |
| babel/util.py | Multi-line regex and function signatures |
| babel/units.py | Expanded format_decimal and dict lookups |
| babel/support.py | Reformatted method calls and class slots |
| babel/plural.py | Multi-line function definitions |
| babel/numbers.py | Multi-line literals and warning calls |
| babel/messages/pofile.py | Expanded constructors and ValueError calls |
| babel/messages/plurals.py | Added # fmt: skip to closing brace |
| babel/messages/mofile.py | Streamlined comprehensions and header packing |
| babel/messages/jslexer.py | Added # fmt: skip, expanded signatures |
| babel/messages/frontend.py | Wrapped lists and log calls |
| babel/messages/extract.py | Expanded type aliases and calls |
| babel/messages/checkers.py | Reformatted TranslationError messages |
| babel/messages/catalog.py | Expanded regex conditions and property defs |
| babel/localtime/_win32.py | Condensed lookup exception |
| babel/localtime/_fallback.py | Added # fmt: skip to a closing parenthesis |
| babel/localedata.py | Reformatted comprehension and constructor |
| babel/lists.py | Multi-line Literal for style argument |
| babel/languages.py | Expanded function signatures |
| babel/dates.py | Reformatted type aliases and functions |
| babel/core.py | Expanded error messages and repr/str methods |
| .pre-commit-config.yaml | Bumped Ruff hook from v0.9.1 to v0.12.0 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Ruff, configures the target line-length to 95 (strikes a balance between the current line lengths in the repo and readability), and formats babel/.
Some artful # fmt: skips, as well as very minor refactoring was done to keep things more readable.
Tests are unformatted in this PR to prove that there are no functional changes in the babel/ code, so as to make this easy to review.
A future PR will likely reformat tests/ similarly, and enforce formatting in CI.