Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
+ Coverage 91.71% 91.98% +0.26%
==========================================
Files 27 27
Lines 4685 4691 +6
==========================================
+ Hits 4297 4315 +18
+ Misses 388 376 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
tomasr8
approved these changes
Jun 10, 2025
tomasr8
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A bit delayed review 😆 Anyway, we should be using pathlib wherever possible, so +1 for this :)
Sorry, something went wrong.
Comment thread
tests/messages/test_frontend.py
| assert mo_file.exists() | ||
|
|
||
|
|
||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #1202 – the deeply nested os.path.join() would have formatted quite poorly, so it felt like a good idea to unnest it – and then I noticed the refactored codepaths weren't tested...