FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Api return 404 when keyword contains point symbol · Issue #1715 · python-gitlab/python-gitlab · GitHub

Repository navigation

Api return 404 when keyword contains point symbol #1715

Description

if the branch/commit keyword contains point symbol . , the api will return 404 response

example:
project.branches.get('stbale-1.x')
project.comits.get('stbale-1.x')


In page: gl_objects/projects.rst

Activity

  1. JohnVillalovos commented on Nov 26, 2021

    Member

    Can you run the following and provide the output?

    #!/usr/bin/env python3
    
    import gitlab
    print("gitlab version:", gitlab.__version__)
    print("gitlab location:", gitlab.__file__)
    
  2. JohnVillalovos commented on Nov 26, 2021

    Member

    As a note, to help your debugging you can do the following, if you want:

    import gitlab
    
    gl = gitlab.Gitlab(... your values ...)
    gl.enable_debug()
    
  3. insoz commented on Nov 26, 2021

    Author

    version: '2.10.1'
    file: '/Users/insoz/code/ops-fast/venv/lib/python3.7/site-packages/gitlab/init.py'

  4. JohnVillalovos commented on Nov 26, 2021

    Member

    Thanks. I have a suspicion it is because of:

    new_path = parsed.path.replace(".", "%2E")

    But not sure if we can just take that out or not. We really need to move to using urllib.parse.quote() for this stuff. Though requests does some it self and I haven't dug into exactly what we are responsible for and what requests will take care of.

  5. JohnVillalovos commented on Nov 26, 2021

    Member

    Related issue: #1356

  6. insoz commented on Nov 26, 2021

    Author

    Thanks! BTW. Do we have some plan to use httpx or something asyncio tool to asynchronous this lib ?

  7. nejch commented on Nov 26, 2021

    Member

    Thanks! BTW. Do we have some plan to use httpx or something asyncio tool to asynchronous this lib ?

    Yes, httpx probably, though it still hasn't reached 1.0 and last I checked was missing some proxy or retry features or so, if I'm not mistaken, can't quite remember.
    But there is an old PR here that already uses it if you really need it (likely missing lots of recent features): #1036. That'll need some major rework to update though once we're ready.

  8. nejch commented on Jan 4, 2022

    Member

    @JohnVillalovos wasn't this fixed by 702e41d? If so we can close it, unless you'd like to add a test for that.

  9. added 3 commits that reference this issue on Jan 4, 2022
    296544a
    30ba7da
    ea97d7a
  10. JohnVillalovos commented on Jan 4, 2022

    Member

    @JohnVillalovos wasn't this fixed by 702e41d? If so we can close it, unless you'd like to add a test for that.

    It was. I just added PR #1800 to prove it works

  11. locked as resolved and limited conversation to collaborators on Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


    Back | FazBrowse Home | New Git URL