Repository navigation
refactor(objects): remove deprecated constants defined in objects - #1593
Merged
JohnVillalovos merged 1 commit intoSep 11, 2021
Merged
JohnVillalovos merged 1 commit into
JohnVillalovos merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
- Coverage 91.59% 91.57% -0.02%
==========================================
Files 74 74
Lines 4272 4263 -9
==========================================
- Hits 3913 3904 -9
Misses 359 359
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
nejch
marked this pull request as draft
September 8, 2021 22:12
BREAKING CHANGE: remove deprecated constants defined in gitlab.v4.objects, and use only gitlab.const module
nejch
force-pushed
the
refactor/consts-in-const-module
branch
from
ce39754 to
b8d379d
Compare
September 11, 2021 10:03
nejch
marked this pull request as ready for review
September 11, 2021 10:13
JohnVillalovos
approved these changes
Sep 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove deprecated constants defined in gitlab.v4.objects, and use only gitlab.const module
FYI: the visibility as int constants can safely be changed to string - they were only used in GitLab API v3 prior to gitlab v9.0. https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/9337