FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: stop encoding '.' to '%2E' by JohnVillalovos · Pull Request #1766 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

fix: stop encoding '.' to '%2E' - #1766

Merged
nejch merged 1 commit into
mainfrom
jlvillal/leave_dot
Dec 21, 2021
ConversationCommits (1)ChecksFiles changed
Merged

fix: stop encoding '.' to '%2E'#1766
nejch merged 1 commit into
mainfrom
jlvillal/leave_dot

Conversation

JohnVillalovos commented Dec 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Forcing the encoding of '.' to '%2E' causes issues. It also goes
against the RFC:
https://datatracker.ietf.org/doc/html/rfc3986.html#section-2.3

From the RFC:
For consistency, percent-encoded octets in the ranges of ALPHA
(%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E),
underscore (%5F), or tilde (%7E) should not be created by URI
producers...

Closes #1006
Related #1356
Related #1561

BREAKING CHANGE: stop encoding '.' to '%2E'. This could potentially be
a breaking change for users who have incorrectly configured GitLab
servers which don't handle period '.' characters correctly.

JohnVillalovos marked this pull request as draft December 19, 2021 23:23
JohnVillalovos force-pushed the jlvillal/leave_dot branch 2 times, most recently from 950b7ba to d12b829 Compare December 19, 2021 23:38

codecov-commenter commented Dec 19, 2021 •
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (ccefe80) to head (702e41d).
Report is 1215 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
- Coverage   91.97%   91.95%   -0.02%     
==========================================
  Files          76       76              
  Lines        4759     4751       -8     
==========================================
- Hits         4377     4369       -8     
  Misses        382      382
Flag Coverage Δ
cli_func_v4 81.30% <100.00%> (-0.04%) ⬇️
py_func_v4 80.67% <100.00%> (-0.04%) ⬇️
unit 83.20% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/client.py 90.00% <100.00%> (-0.11%) ⬇️
gitlab/utils.py 88.00% <100.00%> (-1.66%) ⬇️

JohnVillalovos changed the title Jlvillal/leave dot chore: stop encoding '.' to '%2E' Dec 19, 2021
JohnVillalovos marked this pull request as ready for review December 19, 2021 23:52
JohnVillalovos force-pushed the jlvillal/leave_dot branch 2 times, most recently from d7893c1 to 39155df Compare December 20, 2021 00:15
JohnVillalovos mentioned this pull request Dec 20, 2021
Merged

nejch commented Dec 20, 2021

Copy link
Copy Markdown
Member

@JohnVillalovos could you make this a fix type so it shows in the release and also add the stop encoding '.' to '%2E' sentence at the beginning of the breaking change trailer so it's clear in the release notes in the breaking changes list?

JohnVillalovos commented Dec 20, 2021

Copy link
Copy Markdown
Member Author

@JohnVillalovos could you make this a fix type so it shows in the release and also add the stop encoding '.' to '%2E' sentence at the beginning of the breaking change trailer so it's clear in the release notes in the breaking changes list?

Done I think. Thanks.

nejch reviewed Dec 20, 2021
View reviewed changes
Comment thread gitlab/client.py
fix: stop encoding '.' to '%2E'
702e41d 
Forcing the encoding of '.' to '%2E' causes issues. It also goes
against the RFC:
https://datatracker.ietf.org/doc/html/rfc3986.html#section-2.3

From the RFC:
  For consistency, percent-encoded octets in the ranges of ALPHA
  (%41-%5A and %61-%7A), DIGIT (%30-%39), hyphen (%2D), period (%2E),
  underscore (%5F), or tilde (%7E) should not be created by URI
  producers...

Closes #1006
Related #1356
Related #1561

BREAKING CHANGE: stop encoding '.' to '%2E'. This could potentially be
a breaking change for users who have incorrectly configured GitLab
servers which don't handle period '.' characters correctly.
JohnVillalovos changed the title chore: stop encoding '.' to '%2E' fix: stop encoding '.' to '%2E' Dec 21, 2021
nejch merged commit eef8059 into main Dec 21, 2021
nejch deleted the jlvillal/leave_dot branch December 21, 2021 13:57
This was referenced Jan 5, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nejch nejch left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creation project with "." in name works incorrectly.

3 participants

Back | FazBrowse Home | New Git URL