Repository navigation
fix(cli): project-merge-request-approval-rule - #2066
Merged
nejch merged 1 commit intoJun 20, 2022
Merged
nejch merged 1 commit into
nejch merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JohnVillalovos
marked this pull request as draft
June 11, 2022 02:41
JohnVillalovos
force-pushed
the
jlvillal/approval_rule_id
branch
4 times, most recently
from
35f1f61 to
5f9d1dc
Compare
June 11, 2022 03:10
JohnVillalovos
marked this pull request as ready for review
June 11, 2022 03:11
nejch
reviewed
Jun 11, 2022
nejch
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @JohnVillalovos! Just a quick question there, and I'll just check a bit later today what that other method is doing with the custom ID.
Sorry, something went wrong.
Comment thread
tests/unit/objects/test_project_merge_request_approvals.py
Outdated
Comment thread
gitlab/v4/objects/merge_request_approvals.py
JohnVillalovos
force-pushed
the
jlvillal/approval_rule_id
branch
from
5f9d1dc to
ed3c342
Compare
June 11, 2022 14:33
Using the CLI the command: gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar Would raise an exception. This was due to the fact that `_id_attr` and `_repr_attr` were set for keys which are not returned in the response. Add a unit test which shows the `repr` function now works. Before it did not. This is an EE feature so we can't functional test it. Closes: #2065
JohnVillalovos
force-pushed
the
jlvillal/approval_rule_id
branch
from
ed3c342 to
15a242c
Compare
June 18, 2022 16:05
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #2066 +/- ##
==========================================
+ Coverage 94.62% 94.64% +0.02%
==========================================
Files 78 78
Lines 4983 5002 +19
==========================================
+ Hits 4715 4734 +19
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
nejch
approved these changes
Jun 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the CLI the command:
gitlab project-merge-request-approval-rule list --mr-iid 1 --project-id foo/bar
Would raise an exception. This was due to the fact that _id_attr and
_repr_attr were set for keys which are not returned in the response.
Add a unit test which shows the repr function now works. Before it
did not.
This is an EE feature so we can't functional test it.
Closes: #2065