FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add remote import s3 by abhishekmsingh · Pull Request #2357 · python-gitlab/python-gitlab · GitHub

Repository navigation

feat: add remote import s3 - #2357

Merged
nejch merged 2 commits into
python-gitlab:mainfrom
abhishekmsingh:main
Nov 2, 2022
Merged

nejch merged 2 commits into
python-gitlab:mainfrom
abhishekmsingh:main

Conversation

Copy link
Copy Markdown
Contributor

Closes #2356

abhishekmsingh commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@max-wittig @nejch can you review this PR please? Pretty similar to #2348
There is again a bit of replicated code from import_project function. Can't find a way to refactor it because it is quite small and creating any common entity just feals like overkill. Let me know if anyone has a way to go over it, else I think this much replication might be tolerable.

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great @abhiandthetruth thanks for the quick work again. Just a few quick notes :)

There is again a bit of replicated code from import_project function. Can't find a way to refactor it because it is quite small and creating any common entity just feals like overkill. Let me know if anyone has a way to go over it, else I think this much replication might be tolerable.

I agree, no need yet. We have plenty of other custom methods where this is an issue as well.

I think it would need a lot of rework but another decorator with required/optional payload attributes might make these methods more declarative instead of parsing args inside every method. Something like #1999 if we revive that at some point.

Comment thread gitlab/v4/objects/projects.py Outdated

Copy link
Copy Markdown
Contributor Author

@nejch implemented the suggested changes.

nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a lot for this @abhiandthetruth, as you seem keen on contributing more later I added a small non-blocking note for a potential follow-up :) LGTM!

nejch merged commit 892281e into python-gitlab:main Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support from remote project import from S3

2 participants


Back | FazBrowse Home | New Git URL