FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(api): add ListMixin to remaining *DiscussionNoteManagers by setpill · Pull Request #3423 · python-gitlab/python-gitlab · GitHub

  1. python-gitlab
  2. python-gitlab

Repository navigation

feat(api): add ListMixin to remaining *DiscussionNoteManagers - #3423

Merged
JohnVillalovos merged 1 commit into
python-gitlab:mainfrom
setpill:pcdnm-list
Jul 27, 2026
ConversationCommits (1)ChecksFiles changed
Merged

feat(api): add ListMixin to remaining *DiscussionNoteManagers#3423
JohnVillalovos merged 1 commit into
python-gitlab:mainfrom
setpill:pcdnm-list

Conversation

setpill commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Closes #3422

  1. Add ListMixin to {GroupEpic,ProjectCommit,ProjectSnippet}DiscussionNoteManager
  2. Remove now-unused {Create,Delete,Get,Update}Mixin imports from gitlab/v4/objects/notes.py

Documentation and testing

This PR is a simple remix of #3233. Since it didn't contain tests, I have not added them here either.

codecov Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (ede7fd7) to head (4e53865).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
+ Coverage   92.23%   95.78%   +3.54%     
==========================================
  Files         100      100              
  Lines        6172     6172              
==========================================
+ Hits         5693     5912     +219     
+ Misses        479      260     -219
Flag Coverage Δ
api_func_v4 83.91% <100.00%> (?)
cli_func_v4 78.79% <100.00%> (ø)
unit 90.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/notes.py 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

setpill commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Ping @JohnVillalovos for visibility, since you were involved in the referenced issue/MR.

JohnVillalovos requested a review from Copilot July 27, 2026 03:31
Copilot AI reviewed Jul 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR completes the notes API parity work by ensuring the remaining *DiscussionNoteManager implementations support listing discussion notes (via CRUDMixin, which includes ListMixin), and cleans up unused mixin imports in the notes objects module.

Changes:

  • Switch {GroupEpic,ProjectCommit,ProjectSnippet}DiscussionNoteManager from explicit {Get,Create,Update,Delete}Mixin bases to CRUDMixin (thereby adding list support).
  • Remove now-unused {Create,Delete,Get,Update}Mixin imports from gitlab/v4/objects/notes.py.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JohnVillalovos enabled auto-merge (rebase) July 27, 2026 05:31
JohnVillalovos merged commit 0e2347c into python-gitlab:main Jul 27, 2026
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ProjectCommitDiscussionNoteManager is missing ListMixin

3 participants

Back | FazBrowse Home | New Git URL