Repository navigation
Fix credential hash to return None on empty credentials - #1029
Merged
sdb9696 merged 3 commits intoJul 2, 2024
Merged
sdb9696 merged 3 commits into
sdb9696 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1029 +/- ##
=======================================
Coverage 91.44% 91.45%
=======================================
Files 84 84
Lines 5739 5743 +4
Branches 1395 1397 +2
=======================================
+ Hits 5248 5252 +4
Misses 382 382
Partials 109 109 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
rytilahti
approved these changes
Jul 2, 2024
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
Comment thread
kasa/tests/test_protocol.py
Outdated
Co-authored-by: Teemu R. <tpr@iki.fi>
Merged
sdb9696
added a commit
that referenced
this pull request
Jul 31, 2024
## [0.7.1](https://github.com/python-kasa/python-kasa/tree/0.7.1) (2024-07-31) [Full Changelog](0.7.0.5...0.7.1) **Release highlights:** - This release consists mainly of bugfixes and project improvements. - There is also new support for Tapo T100 motion sensors. - The CLI now supports child devices on all applicable commands. **Implemented enhancements:** - Expose reboot action [\#1073](#1073) (@rytilahti) - Decrypt KLAP data from PCAP files [\#1041](#1041) (@clstrickland) - Support child devices in all applicable cli commands [\#1020](#1020) (@sdb9696) **Fixed bugs:** - Fix iot light effect brightness [\#1092](#1092) (@sdb9696) - Enable setting brightness with color temp for smart devices [\#1091](#1091) (@sdb9696) - Do not send light\_on value to iot bulb set\_state [\#1090](#1090) (@sdb9696) - Allow erroring modules to recover [\#1080](#1080) (@sdb9696) - Raise KasaException on decryption errors [\#1078](#1078) (@sdb9696) - Update smart request parameter handling [\#1061](#1061) (@sdb9696) - Fix light preset module when list contains lighting effects [\#1048](#1048) (@sdb9696) - Handle module errors more robustly and add query params to light preset and transition [\#1036](#1036) (@sdb9696) - Fix credential hash to return None on empty credentials [\#1029](#1029) (@sdb9696) **Added support for devices:** - Add support for T100 motion sensor [\#1079](#1079) (@rytilahti) **Project maintenance:** - Bump project version to 0.7.0.5 [\#1087](#1087) (@sdb9696) - Fix generate\_supported pre commit to run in venv [\#1085](#1085) (@sdb9696) - Fix intermittently failing decryption error test [\#1082](#1082) (@sdb9696) - Fix mypy pre-commit hook on windows [\#1081](#1081) (@sdb9696) - Update RELEASING.md for patch releases [\#1076](#1076) (@sdb9696) - Use monotonic time for query timing [\#1070](#1070) (@sdb9696) - Fix parse\_pcap\_klap on windows and support default credentials [\#1068](#1068) (@sdb9696) - Add fixture file for KP405 fw 1.0.6 [\#1063](#1063) (@daleye) - Bump project version to 0.7.0.3 [\#1053](#1053) (@sdb9696) - Add KP400\(US\) v1.0.4 fixture [\#1051](#1051) (@gimpy88) - Add new HS220 kasa aes fixture [\#1050](#1050) (@sdb9696) - Add KS205\(US\) v1.1.0 fixture [\#1049](#1049) (@gimpy88) - Add KS200M\(US\) v1.0.11 fixture [\#1047](#1047) (@sdb9696) - Add KS225\(US\) v1.1.0 fixture [\#1046](#1046) (@sdb9696) - Split out main cli module into lazily loaded submodules [\#1039](#1039) (@sdb9696) - Structure cli into a package [\#1038](#1038) (@sdb9696) - Add KP400 v1.0.3 fixture [\#1037](#1037) (@gimpy88) - Add L920\(EU\) v1.1.3 fixture [\#1031](#1031) (@rytilahti) - Update changelog generator config [\#1030](#1030) (@sdb9696)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
…1029) If discovery is triggered without credentials and discovers devices requiring authentication, blank credentials are used to initialise the protocols and no connection is actually made. In this instance we should not return the credentials_hash for blank credentials as it will be invalid.
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.1](https://github.com/python-kasa/python-kasa/tree/0.7.1) (2024-07-31) [Full Changelog](python-kasa/python-kasa@0.7.0.5...0.7.1) **Release highlights:** - This release consists mainly of bugfixes and project improvements. - There is also new support for Tapo T100 motion sensors. - The CLI now supports child devices on all applicable commands. **Implemented enhancements:** - Expose reboot action [\python-kasa#1073](python-kasa#1073) (@rytilahti) - Decrypt KLAP data from PCAP files [\python-kasa#1041](python-kasa#1041) (@clstrickland) - Support child devices in all applicable cli commands [\python-kasa#1020](python-kasa#1020) (@sdb9696) **Fixed bugs:** - Fix iot light effect brightness [\python-kasa#1092](python-kasa#1092) (@sdb9696) - Enable setting brightness with color temp for smart devices [\python-kasa#1091](python-kasa#1091) (@sdb9696) - Do not send light\_on value to iot bulb set\_state [\python-kasa#1090](python-kasa#1090) (@sdb9696) - Allow erroring modules to recover [\python-kasa#1080](python-kasa#1080) (@sdb9696) - Raise KasaException on decryption errors [\python-kasa#1078](python-kasa#1078) (@sdb9696) - Update smart request parameter handling [\python-kasa#1061](python-kasa#1061) (@sdb9696) - Fix light preset module when list contains lighting effects [\python-kasa#1048](python-kasa#1048) (@sdb9696) - Handle module errors more robustly and add query params to light preset and transition [\python-kasa#1036](python-kasa#1036) (@sdb9696) - Fix credential hash to return None on empty credentials [\python-kasa#1029](python-kasa#1029) (@sdb9696) **Added support for devices:** - Add support for T100 motion sensor [\python-kasa#1079](python-kasa#1079) (@rytilahti) **Project maintenance:** - Bump project version to 0.7.0.5 [\python-kasa#1087](python-kasa#1087) (@sdb9696) - Fix generate\_supported pre commit to run in venv [\python-kasa#1085](python-kasa#1085) (@sdb9696) - Fix intermittently failing decryption error test [\python-kasa#1082](python-kasa#1082) (@sdb9696) - Fix mypy pre-commit hook on windows [\python-kasa#1081](python-kasa#1081) (@sdb9696) - Update RELEASING.md for patch releases [\python-kasa#1076](python-kasa#1076) (@sdb9696) - Use monotonic time for query timing [\python-kasa#1070](python-kasa#1070) (@sdb9696) - Fix parse\_pcap\_klap on windows and support default credentials [\python-kasa#1068](python-kasa#1068) (@sdb9696) - Add fixture file for KP405 fw 1.0.6 [\python-kasa#1063](python-kasa#1063) (@daleye) - Bump project version to 0.7.0.3 [\python-kasa#1053](python-kasa#1053) (@sdb9696) - Add KP400\(US\) v1.0.4 fixture [\python-kasa#1051](python-kasa#1051) (@gimpy88) - Add new HS220 kasa aes fixture [\python-kasa#1050](python-kasa#1050) (@sdb9696) - Add KS205\(US\) v1.1.0 fixture [\python-kasa#1049](python-kasa#1049) (@gimpy88) - Add KS200M\(US\) v1.0.11 fixture [\python-kasa#1047](python-kasa#1047) (@sdb9696) - Add KS225\(US\) v1.1.0 fixture [\python-kasa#1046](python-kasa#1046) (@sdb9696) - Split out main cli module into lazily loaded submodules [\python-kasa#1039](python-kasa#1039) (@sdb9696) - Structure cli into a package [\python-kasa#1038](python-kasa#1038) (@sdb9696) - Add KP400 v1.0.3 fixture [\python-kasa#1037](python-kasa#1037) (@gimpy88) - Add L920\(EU\) v1.1.3 fixture [\python-kasa#1031](python-kasa#1031) (@rytilahti) - Update changelog generator config [\python-kasa#1030](python-kasa#1030) (@sdb9696)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If discovery is triggered without credentials and discovers devices requiring authentication, blank credentials are used to initialise the protocols and no connection is actually made. In this instance we should not return the credentials_hash for blank credentials as it will be invalid.
N.B. device already defines credentials_hash as str | None so shouldn't be any backwards compatibility issues.