Handle module errors more robustly and add query params to light preset and transition by sdb9696 · Pull Request #1036 · python-kasa/python-kasa · GitHub

This PR ensures that all modules try to access their data in _post_update_hook in a safe manner and disable themselves if there's an error.

It also adds parameters to get_preset_rules and get_on_off_gradually_info to fix issues with recent firmware updates. #1033.

…y queries

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (9cffbe9) to head (ba95156).
Report is 81 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
+ Coverage   91.98%   92.03%   +0.04%     
==========================================
  Files          84       84              
  Lines        5762     5798      +36     
  Branches     1395     1400       +5     
==========================================
+ Hits         5300     5336      +36     
  Misses        356      356              
  Partials      106      106

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A lot of the hub child devices appear to incorrectly expose a module query even though they don't call/access any modules. In order to support the self.data check in this PR they need to expose an empty query dict.

No longer required or reachable as the self.data check in this PR would cause the module to be removed before _initialize_features is called.

This still needs to be tested as working with the affected devices. Will send an empty {} instead of null for params.

get_on_off_gradually_info now confirmed as working in #1033

…et and transition (#1036) Ensures that all modules try to access their data in `_post_update_hook` in a safe manner and disable themselves if there's an error. Also adds parameters to get_preset_rules and get_on_off_gradually_info to fix issues with recent firmware updates. [#1033](#1033)

…et and transition (#1043) Ensures that all modules try to access their data in `_post_update_hook` in a safe manner and disable themselves if there's an error. Also adds parameters to get_preset_rules and get_on_off_gradually_info to fix issues with recent firmware updates. Cherry pick of [#1036](#1036) to patch

## [0.7.1](https://github.com/python-kasa/python-kasa/tree/0.7.1) (2024-07-31) [Full Changelog](0.7.0.5...0.7.1) **Release highlights:** - This release consists mainly of bugfixes and project improvements. - There is also new support for Tapo T100 motion sensors. - The CLI now supports child devices on all applicable commands. **Implemented enhancements:** - Expose reboot action [\#1073](#1073) (@rytilahti) - Decrypt KLAP data from PCAP files [\#1041](#1041) (@clstrickland) - Support child devices in all applicable cli commands [\#1020](#1020) (@sdb9696) **Fixed bugs:** - Fix iot light effect brightness [\#1092](#1092) (@sdb9696) - Enable setting brightness with color temp for smart devices [\#1091](#1091) (@sdb9696) - Do not send light\_on value to iot bulb set\_state [\#1090](#1090) (@sdb9696) - Allow erroring modules to recover [\#1080](#1080) (@sdb9696) - Raise KasaException on decryption errors [\#1078](#1078) (@sdb9696) - Update smart request parameter handling [\#1061](#1061) (@sdb9696) - Fix light preset module when list contains lighting effects [\#1048](#1048) (@sdb9696) - Handle module errors more robustly and add query params to light preset and transition [\#1036](#1036) (@sdb9696) - Fix credential hash to return None on empty credentials [\#1029](#1029) (@sdb9696) **Added support for devices:** - Add support for T100 motion sensor [\#1079](#1079) (@rytilahti) **Project maintenance:** - Bump project version to 0.7.0.5 [\#1087](#1087) (@sdb9696) - Fix generate\_supported pre commit to run in venv [\#1085](#1085) (@sdb9696) - Fix intermittently failing decryption error test [\#1082](#1082) (@sdb9696) - Fix mypy pre-commit hook on windows [\#1081](#1081) (@sdb9696) - Update RELEASING.md for patch releases [\#1076](#1076) (@sdb9696) - Use monotonic time for query timing [\#1070](#1070) (@sdb9696) - Fix parse\_pcap\_klap on windows and support default credentials [\#1068](#1068) (@sdb9696) - Add fixture file for KP405 fw 1.0.6 [\#1063](#1063) (@daleye) - Bump project version to 0.7.0.3 [\#1053](#1053) (@sdb9696) - Add KP400\(US\) v1.0.4 fixture [\#1051](#1051) (@gimpy88) - Add new HS220 kasa aes fixture [\#1050](#1050) (@sdb9696) - Add KS205\(US\) v1.1.0 fixture [\#1049](#1049) (@gimpy88) - Add KS200M\(US\) v1.0.11 fixture [\#1047](#1047) (@sdb9696) - Add KS225\(US\) v1.1.0 fixture [\#1046](#1046) (@sdb9696) - Split out main cli module into lazily loaded submodules [\#1039](#1039) (@sdb9696) - Structure cli into a package [\#1038](#1038) (@sdb9696) - Add KP400 v1.0.3 fixture [\#1037](#1037) (@gimpy88) - Add L920\(EU\) v1.1.3 fixture [\#1031](#1031) (@rytilahti) - Update changelog generator config [\#1030](#1030) (@sdb9696)

…et and transition (python-kasa#1036) Ensures that all modules try to access their data in `_post_update_hook` in a safe manner and disable themselves if there's an error. Also adds parameters to get_preset_rules and get_on_off_gradually_info to fix issues with recent firmware updates. [python-kasa#1033](python-kasa#1033)

…et and transition (python-kasa#1043) Ensures that all modules try to access their data in `_post_update_hook` in a safe manner and disable themselves if there's an error. Also adds parameters to get_preset_rules and get_on_off_gradually_info to fix issues with recent firmware updates. Cherry pick of [python-kasa#1036](python-kasa#1036) to patch

## [0.7.1](https://github.com/python-kasa/python-kasa/tree/0.7.1) (2024-07-31) [Full Changelog](python-kasa/python-kasa@0.7.0.5...0.7.1) **Release highlights:** - This release consists mainly of bugfixes and project improvements. - There is also new support for Tapo T100 motion sensors. - The CLI now supports child devices on all applicable commands. **Implemented enhancements:** - Expose reboot action [\python-kasa#1073](python-kasa#1073) (@rytilahti) - Decrypt KLAP data from PCAP files [\python-kasa#1041](python-kasa#1041) (@clstrickland) - Support child devices in all applicable cli commands [\python-kasa#1020](python-kasa#1020) (@sdb9696) **Fixed bugs:** - Fix iot light effect brightness [\python-kasa#1092](python-kasa#1092) (@sdb9696) - Enable setting brightness with color temp for smart devices [\python-kasa#1091](python-kasa#1091) (@sdb9696) - Do not send light\_on value to iot bulb set\_state [\python-kasa#1090](python-kasa#1090) (@sdb9696) - Allow erroring modules to recover [\python-kasa#1080](python-kasa#1080) (@sdb9696) - Raise KasaException on decryption errors [\python-kasa#1078](python-kasa#1078) (@sdb9696) - Update smart request parameter handling [\python-kasa#1061](python-kasa#1061) (@sdb9696) - Fix light preset module when list contains lighting effects [\python-kasa#1048](python-kasa#1048) (@sdb9696) - Handle module errors more robustly and add query params to light preset and transition [\python-kasa#1036](python-kasa#1036) (@sdb9696) - Fix credential hash to return None on empty credentials [\python-kasa#1029](python-kasa#1029) (@sdb9696) **Added support for devices:** - Add support for T100 motion sensor [\python-kasa#1079](python-kasa#1079) (@rytilahti) **Project maintenance:** - Bump project version to 0.7.0.5 [\python-kasa#1087](python-kasa#1087) (@sdb9696) - Fix generate\_supported pre commit to run in venv [\python-kasa#1085](python-kasa#1085) (@sdb9696) - Fix intermittently failing decryption error test [\python-kasa#1082](python-kasa#1082) (@sdb9696) - Fix mypy pre-commit hook on windows [\python-kasa#1081](python-kasa#1081) (@sdb9696) - Update RELEASING.md for patch releases [\python-kasa#1076](python-kasa#1076) (@sdb9696) - Use monotonic time for query timing [\python-kasa#1070](python-kasa#1070) (@sdb9696) - Fix parse\_pcap\_klap on windows and support default credentials [\python-kasa#1068](python-kasa#1068) (@sdb9696) - Add fixture file for KP405 fw 1.0.6 [\python-kasa#1063](python-kasa#1063) (@daleye) - Bump project version to 0.7.0.3 [\python-kasa#1053](python-kasa#1053) (@sdb9696) - Add KP400\(US\) v1.0.4 fixture [\python-kasa#1051](python-kasa#1051) (@gimpy88) - Add new HS220 kasa aes fixture [\python-kasa#1050](python-kasa#1050) (@sdb9696) - Add KS205\(US\) v1.1.0 fixture [\python-kasa#1049](python-kasa#1049) (@gimpy88) - Add KS200M\(US\) v1.0.11 fixture [\python-kasa#1047](python-kasa#1047) (@sdb9696) - Add KS225\(US\) v1.1.0 fixture [\python-kasa#1046](python-kasa#1046) (@sdb9696) - Split out main cli module into lazily loaded submodules [\python-kasa#1039](python-kasa#1039) (@sdb9696) - Structure cli into a package [\python-kasa#1038](python-kasa#1038) (@sdb9696) - Add KP400 v1.0.3 fixture [\python-kasa#1037](python-kasa#1037) (@gimpy88) - Add L920\(EU\) v1.1.3 fixture [\python-kasa#1031](python-kasa#1031) (@rytilahti) - Update changelog generator config [\python-kasa#1030](python-kasa#1030) (@sdb9696)

sdb9696 added 2 commits July 3, 2024 06:12

Add rule params to get_preset_rules

ec1d827

Handle module errors more robustly

3cfb689

sdb9696 mentioned this pull request Jul 3, 2024

Kasa Smart Dimmer KS225 - KLAP Support #1033

Closed

gimpy88 mentioned this pull request Jul 3, 2024

Add KP400 v1.0.3 fixture #1037

Merged

sdb9696 added 2 commits July 3, 2024 08:30

Add check for data errors and ensure sysinfo only modules return empt…

291e102

…y queries

Fix test with child device query

ce4aaf9

sdb9696 added 4 commits July 3, 2024 11:28

Add tests for disabling modules

39e3d05

Fix test

92d8031

Fix coverage

4ede248

Try fix on off gradually

79e1f66

sdb9696 mentioned this pull request Jul 3, 2024

S505d invalid authentication #888

Closed

sdb9696 commented Jul 3, 2024

View reviewed changes

Catch broad exceptions when trying post update hook

ba95156

sdb9696 changed the title Handle module errors more robustly and add rule params to LightPreset query Handle module errors more robustly and add query params to light preset and transition Jul 4, 2024

sdb9696 merged commit 905a148 into master Jul 4, 2024

sdb9696 deleted the fix/ks225_params branch July 4, 2024 07:02

sdb9696 mentioned this pull request Jul 4, 2024

Handle module errors more robustly and add query params to light preset and transition #1043

Merged

sdb9696 added the bug Something isn't working label Jul 11, 2024

sdb9696 mentioned this pull request Jul 31, 2024

Prepare 0.7.1 #1094

Merged

-                      if not isinstance(self.data, dict):
-                          _LOGGER.warning(
-                              "No data available for module, skipping %s: %s", self, self.data
-                          )
-                          return

Handle module errors more robustly and add query params to light preset and transition by sdb9696 · Pull Request #1036 · python-kasa/python-kasa · GitHub

Repository navigation

Handle module errors more robustly and add query params to light preset and transition - #1036

Handle module errors more robustly and add query params to light preset and transition#1036
sdb9696 merged 9 commits into
masterfrom
fix/ks225_params

sdb9696 commented Jul 3, 2024 •
edited
Loading

Uh oh!

Uh oh!

codecov Bot commented Jul 3, 2024 •
edited
Loading

Uh oh!

Uh oh!

sdb9696 Jul 3, 2024

Uh oh!

sdb9696 Jul 3, 2024

Uh oh!

sdb9696 Jul 3, 2024

Uh oh!

sdb9696 Jul 4, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

+                  def query(self) -> dict:
+                      """Query to execute during the update cycle."""
+                      return {}

+                      return SmartRequest(
+                          "get_on_off_gradually_info", params or SmartRequest.SmartRequestParams()
+                      )

Handle module errors more robustly and add query params to light preset and transition by sdb9696 · Pull Request #1036 · python-kasa/python-kasa · GitHub

Repository navigation

Handle module errors more robustly and add query params to light preset and transition - #1036

Handle module errors more robustly and add query params to light preset and transition#1036sdb9696 merged 9 commits intomasterpython-kasa/python-kasa:masterfrom fix/ks225_paramspython-kasa/python-kasa:fix/ks225_paramsCopy head branch name to clipboard

Conversation

sdb9696 commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sdb9696 Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

sdb9696 Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

sdb9696 Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

sdb9696 Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Handle module errors more robustly and add query params to light preset and transition#1036
sdb9696 merged 9 commits into
masterfrom
fix/ks225_params

sdb9696 commented Jul 3, 2024 •
edited
Loading

codecov Bot commented Jul 3, 2024 •
edited
Loading