Repository navigation
Remove async magic patch from tests - #1146
Merged
rytilahti merged 1 commit intoOct 2, 2024
Merged
rytilahti merged 1 commit into
rytilahti merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1146 +/- ##
=======================================
Coverage 92.59% 92.59%
=======================================
Files 96 96
Lines 6119 6119
Branches 1514 1514
=======================================
Hits 5666 5666
Misses 354 354
Partials 99 99 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
sdb9696
marked this pull request as ready for review
October 1, 2024 13:39
rytilahti
reviewed
Oct 1, 2024
rytilahti
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Asyncmock changes look good, but was the functional change intentional?
Sorry, something went wrong.
Comment thread
kasa/smart/smartmodule.py
sdb9696
force-pushed
the
janitor/remove_test_magic
branch
from
c9e24a8 to
cdf7f19
Compare
October 2, 2024 15:01
rytilahti
approved these changes
Oct 2, 2024
Merged
sdb9696
added a commit
that referenced
this pull request
Oct 8, 2024
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08) [Full Changelog](0.7.4...0.7.5) **Release summary:** - Fix for KP303 on Firmware 1.0.6 - Fix for `on_since` value jitter - Various maintenance items **Breaking changes:** - Make iot time timezone aware [\#1147](#1147) (@sdb9696) **Fixed bugs:** - Use tzinfo in time constructor instead of astime for iot devices [\#1158](#1158) (@sdb9696) - Send empty dictionary instead of null for iot queries [\#1145](#1145) (@sdb9696) - Stabilise on\_since value for smart devices [\#1144](#1144) (@sdb9696) - parse\_pcap\_klap: require source host [\#1137](#1137) (@rytilahti) - parse\_pcap\_klap: use request\_uri for matching the response [\#1136](#1136) (@rytilahti) **Project maintenance:** - Cache zoneinfo for smart devices [\#1156](#1156) (@sdb9696) - Correctly define SmartModule.call as an async function [\#1148](#1148) (@sdb9696) - Remove async magic patch from tests [\#1146](#1146) (@sdb9696) - Move feature initialization from \_\_init\_\_ to \_initialize\_features [\#1140](#1140) (@rytilahti)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
Not required since AsyncMock available in python 3.8 and probably better to keep magic to a minimum.
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08) [Full Changelog](python-kasa/python-kasa@0.7.4...0.7.5) **Release summary:** - Fix for KP303 on Firmware 1.0.6 - Fix for `on_since` value jitter - Various maintenance items **Breaking changes:** - Make iot time timezone aware [\python-kasa#1147](python-kasa#1147) (@sdb9696) **Fixed bugs:** - Use tzinfo in time constructor instead of astime for iot devices [\python-kasa#1158](python-kasa#1158) (@sdb9696) - Send empty dictionary instead of null for iot queries [\python-kasa#1145](python-kasa#1145) (@sdb9696) - Stabilise on\_since value for smart devices [\python-kasa#1144](python-kasa#1144) (@sdb9696) - parse\_pcap\_klap: require source host [\python-kasa#1137](python-kasa#1137) (@rytilahti) - parse\_pcap\_klap: use request\_uri for matching the response [\python-kasa#1136](python-kasa#1136) (@rytilahti) **Project maintenance:** - Cache zoneinfo for smart devices [\python-kasa#1156](python-kasa#1156) (@sdb9696) - Correctly define SmartModule.call as an async function [\python-kasa#1148](python-kasa#1148) (@sdb9696) - Remove async magic patch from tests [\python-kasa#1146](python-kasa#1146) (@sdb9696) - Move feature initialization from \_\_init\_\_ to \_initialize\_features [\python-kasa#1140](python-kasa#1140) (@rytilahti)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not required since AsyncMock available in python 3.8 and probably better to keep magic to a minimum.