Repository navigation
Make iot time timezone aware - #1147
Merged
sdb9696 merged 8 commits intoOct 8, 2024
Merged
sdb9696 merged 8 commits into
sdb9696 merged 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 94.38202% with 5 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 92.59% 92.57% -0.03%
==========================================
Files 96 97 +1
Lines 6119 6168 +49
Branches 1514 1523 +9
==========================================
+ Hits 5666 5710 +44
- Misses 354 357 +3
- Partials 99 101 +2 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
sdb9696
force-pushed
the
feat/iot_timezone
branch
from
ec37b45 to
7778d2b
Compare
October 1, 2024 17:40
rytilahti
reviewed
Oct 1, 2024
Comment thread
kasa/iot/modules/time.py
Outdated
sdb9696
force-pushed
the
feat/iot_timezone
branch
from
535dce2 to
4d36a92
Compare
October 2, 2024 14:11
sdb9696
marked this pull request as ready for review
October 2, 2024 14:46
rytilahti
reviewed
Oct 2, 2024
rytilahti
approved these changes
Oct 7, 2024
Merged
sdb9696
added a commit
that referenced
this pull request
Oct 8, 2024
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08) [Full Changelog](0.7.4...0.7.5) **Release summary:** - Fix for KP303 on Firmware 1.0.6 - Fix for `on_since` value jitter - Various maintenance items **Breaking changes:** - Make iot time timezone aware [\#1147](#1147) (@sdb9696) **Fixed bugs:** - Use tzinfo in time constructor instead of astime for iot devices [\#1158](#1158) (@sdb9696) - Send empty dictionary instead of null for iot queries [\#1145](#1145) (@sdb9696) - Stabilise on\_since value for smart devices [\#1144](#1144) (@sdb9696) - parse\_pcap\_klap: require source host [\#1137](#1137) (@rytilahti) - parse\_pcap\_klap: use request\_uri for matching the response [\#1136](#1136) (@rytilahti) **Project maintenance:** - Cache zoneinfo for smart devices [\#1156](#1156) (@sdb9696) - Correctly define SmartModule.call as an async function [\#1148](#1148) (@sdb9696) - Remove async magic patch from tests [\#1146](#1146) (@sdb9696) - Move feature initialization from \_\_init\_\_ to \_initialize\_features [\#1140](#1140) (@rytilahti)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
Also makes on_since for iot devices use device time. Changes the return value for device.timezone to be tzinfo instead of a dict.
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.5](https://github.com/python-kasa/python-kasa/tree/0.7.5) (2024-10-08) [Full Changelog](python-kasa/python-kasa@0.7.4...0.7.5) **Release summary:** - Fix for KP303 on Firmware 1.0.6 - Fix for `on_since` value jitter - Various maintenance items **Breaking changes:** - Make iot time timezone aware [\python-kasa#1147](python-kasa#1147) (@sdb9696) **Fixed bugs:** - Use tzinfo in time constructor instead of astime for iot devices [\python-kasa#1158](python-kasa#1158) (@sdb9696) - Send empty dictionary instead of null for iot queries [\python-kasa#1145](python-kasa#1145) (@sdb9696) - Stabilise on\_since value for smart devices [\python-kasa#1144](python-kasa#1144) (@sdb9696) - parse\_pcap\_klap: require source host [\python-kasa#1137](python-kasa#1137) (@rytilahti) - parse\_pcap\_klap: use request\_uri for matching the response [\python-kasa#1136](python-kasa#1136) (@rytilahti) **Project maintenance:** - Cache zoneinfo for smart devices [\python-kasa#1156](python-kasa#1156) (@sdb9696) - Correctly define SmartModule.call as an async function [\python-kasa#1148](python-kasa#1148) (@sdb9696) - Remove async magic patch from tests [\python-kasa#1146](python-kasa#1146) (@sdb9696) - Move feature initialization from \_\_init\_\_ to \_initialize\_features [\python-kasa#1140](python-kasa#1140) (@rytilahti)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #980
Breaking:
This changes the return value for device.timezone to be tzinfo so marking as a breaking change. Previous return values of {"timezone": ti.tzname()} for smart and {"index": 39, "error_code": 0} for iot were not particularly helpful so I don't think we need to be backwards compatible.
Requires the tzdata to be installed on windows as there is no system installation.
N.B. The get_timezone_index should allow setting the iot device timezone from any IANA timezone key.
The mapping for the iot firmware index / internal name to IANA timezone is below (n.b. Magadan index 100 is duplicated with no side-effects):