Repository navigation
Simplify discovery query, refactor dump-devinfo - #147
rytilahti merged 3 commits into
Conversation
Sorry, something went wrong.
|
Other than the conflicting file it looks good to me. |
Sorry, something went wrong.
|
@rytilahti I finally had a chance to check out the dump_devinfo.py script that you mentioned in #141 and it was able to successfully dump information from my KL125 bulb and a new HS200 switch. |
Sorry, something went wrong.
|
@brianthedavis would you mind creating a PR to add the resulting files json (for KL125 at least, for HS200 in case it's a different hardware version than the existing ones) to https://github.com/python-kasa/python-kasa/tree/master/kasa/tests/fixtures and adding KL125 to https://github.com/python-kasa/python-kasa/blob/master/kasa/tests/conftest.py#L30 ? |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
+ Coverage 73.26% 74.42% +1.15%
==========================================
Files 11 11
Lines 1242 1220 -22
Branches 183 177 -6
==========================================
- Hits 910 908 -2
+ Misses 299 279 -20
Partials 33 33
Continue to review full report at Codecov.
|
Sorry, something went wrong.
* Use only system:get_sysinfo for discovery * move dump-devinfo into a separate tool under devtools * Fix linting
This modifies the discovery to query only system:get_sysinfo as querying multiple modules at once is known to have issues with some devices.
This PR also moves the dump-devinfo functionality to a separately shipped file under devtools, which should also now allow generating fixture files for devices that do not support querying multiple modules at once.
Fixes #105, fixes #113, related to #120