FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Get rid of expected failures in tokenizer tests by mistotebe · Pull Request #283 · python-ldap/python-ldap · GitHub

/ python-ldap Public

Get rid of expected failures in tokenizer tests - #283

Merged
encukou merged 2 commits into
python-ldap:masterfrom
mistotebe:tokenizer
May 6, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Get rid of expected failures in tokenizer tests#283
encukou merged 2 commits into
python-ldap:masterfrom
mistotebe:tokenizer

Conversation

mistotebe commented May 2, 2019

Copy link
Copy Markdown
Contributor

One of the failures actually stems from using the wrong method. Extending the tokenizer to deal with escapes gets rid of the other.

codecov Bot commented May 2, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #283 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage    71.1%   71.11%   +<.01%     
==========================================
  Files          49       49              
  Lines        4818     4819       +1     
  Branches      812      812              
==========================================
+ Hits         3426     3427       +1     
- Misses       1056     1057       +1     
+ Partials      336      335       -1
Impacted Files Coverage Δ
Lib/ldap/schema/tokenizer.py 97.91% <100%> (+0.04%) ⬆️
Lib/ldap/controls/deref.py 57.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf9dc4...60bc814. Read the comment docs.

mistotebe mentioned this pull request May 17, 2019
Merged

encukou commented Sep 20, 2019

Copy link
Copy Markdown
Member

I am out of my depth here: the details of LDAP tokenization and Oracle Internet Directory escape me :(
@tiran, do you want to review this?

encukou approved these changes Jan 29, 2020
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No response :(
I can't find an issue here. Existing tests pass and expected failures are solved.

encukou merged commit 7e084ae into python-ldap:master May 6, 2020
tiran added this to the 3.3 milestone May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL