FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Additional exception fields by mistotebe · Pull Request #288 · python-ldap/python-ldap · GitHub

Additional exception fields - #288

Merged
encukou merged 7 commits into
python-ldap:masterfrom
mistotebe:exceptions
Jun 5, 2020
Merged

Additional exception fields#288
encukou merged 7 commits into
python-ldap:masterfrom
mistotebe:exceptions

Conversation

Copy link
Copy Markdown
Contributor

Work to improve how we raise exceptions on result, deals with controls and msgid being missing (#177, #208).

Ready for merging (pending #282, #283, #284 have been accepted) apart from last commit which is mainly here for initial review and can be split into its own PR if you want.

somay commented May 26, 2019

Copy link
Copy Markdown

LGTM regarding #208 .
My patch is already merged well.

Copy link
Copy Markdown
Contributor Author

@tiran, @encukou any thoughts on this and the dependent PRs?

encukou commented Jan 29, 2020

Copy link
Copy Markdown
Member

This is out of my depth.
@tiran, do you want to review this?

mistotebe marked this pull request as ready for review April 9, 2020 08:18

Copy link
Copy Markdown
Contributor Author

Any ideas on a review? Without this it's impossible to have more than one operation pending on a connection.

encukou commented Apr 29, 2020

Copy link
Copy Markdown
Member

My review will be sub-par, but it looks like I'll need to do it to move this forward. I'll dedicate a day next week to python-ldap.

Copy link
Copy Markdown
Contributor Author

Thanks, I'll rebase it in the meantime.

mistotebe force-pushed the exceptions branch 4 times, most recently from 82f050b to 8492b16 Compare April 30, 2020 11:34

Copy link
Copy Markdown
Contributor Author

Only fails on the same doctest as master now.

encukou commented May 6, 2020

Copy link
Copy Markdown
Member

The last commit should go into a separate PR:

Comment thread Modules/constants.c
Comment thread Modules/LDAPObject.c
Comment thread Modules/constants.c Outdated
Comment thread Modules/LDAPObject.c

Copy link
Copy Markdown
Contributor Author

I've moved the WIP commit into its own branch, but kept the .errnum one in for now. Let me know if it should be moved too.

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!
Thank you for the change, and apologies for the delay in reviewing.

encukou merged commit 3c0f7ef into python-ldap:master Jun 5, 2020
tiran added this to the 3.3 milestone Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL