| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
LGTM regarding #208 . |
Sorry, something went wrong.
Sorry, something went wrong.
|
This is out of my depth. |
Sorry, something went wrong.
|
Any ideas on a review? Without this it's impossible to have more than one operation pending on a connection. |
Sorry, something went wrong.
|
My review will be sub-par, but it looks like I'll need to do it to move this forward. I'll dedicate a day next week to python-ldap. |
Sorry, something went wrong.
|
Thanks, I'll rebase it in the meantime. |
Sorry, something went wrong.
|
Only fails on the same doctest as master now. |
Sorry, something went wrong.
|
The last commit should go into a separate PR:
|
Sorry, something went wrong.
|
I've moved the WIP commit into its own branch, but kept the .errnum one in for now. Let me know if it should be moved too. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good!
Thank you for the change, and apologies for the delay in reviewing.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Work to improve how we raise exceptions on result, deals with controls and msgid being missing (#177, #208).
Ready for merging (pending #282, #283, #284 have been accepted) apart from last commit which is mainly here for initial review and can be split into its own PR if you want.