Make workspace/didChangeConfig work with notebook documents - #462
Merged
ccordoba12 merged 6 commits intoOct 18, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tkrabel-db
commented
Oct 17, 2023
Comment thread
pylsp/workspace.py
Outdated
tkrabel-db
commented
Oct 17, 2023
Comment thread
pylsp/workspace.py
Outdated
tkrabel-db
commented
Oct 17, 2023
Comment thread
pylsp/plugins/rope_autoimport.py
Outdated
tkrabel-db
commented
Oct 17, 2023
Comment thread
pylsp/plugins/rope_autoimport.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@ccordoba12 @rchl this is ready for review |
Sorry, something went wrong.
ccordoba12
reviewed
Oct 17, 2023
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Some minor comments for you @tkrabel-db, the rest looks good to me.
Sorry, something went wrong.
Comment thread
pylsp/plugins/rope_autoimport.py
Outdated
Comment thread
pylsp/plugins/rope_autoimport.py
Outdated
Comment thread
pylsp/workspace.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@ccordoba12 I addressed the comments. Thanks for the swift feedback! |
Sorry, something went wrong.
2 tasks
ccordoba12
approved these changes
Oct 18, 2023
ccordoba12
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good to me now, thanks @tkrabel-db!
Sorry, something went wrong.
staticf0x
pushed a commit
to staticf0x/python-lsp-server
that referenced
this pull request
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What change is proposed?
Notebook doesn't support update_config, as configuration is handled on the cell level. This makes workspace/didChangeConfguration error when there are notebook documents in the workspace. This PR fixes that.
How is this tested?