typing - exceptions.py - #74
Merged
starcat37 merged 5 commits intoAug 31, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
starcat37
marked this pull request as ready for review
August 30, 2023 07:11
starcat37
requested review from
dongwook-chan,
heehehe,
mikaniz,
mjs1995 and
sean-k1
August 31, 2023 04:14
heehehe
approved these changes
Aug 31, 2023
heehehe
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
고생 많으셨습니다!! merge하실 때 Squash and merge로, 커밋 메시지는 docs: add typing in exceptions.py 등으로 부탁드립니다!
Sorry, something went wrong.
Comment thread
pymysqlreplication/tests/test_basic.py
Outdated
mjs1995
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO