typing - 'gtid.py', 'exceptions.py', 'binlogstream.py', 'packet.py' - #85
Open
heehehe wants to merge 7 commits into
Open
typing - 'gtid.py', 'exceptions.py', 'binlogstream.py', 'packet.py'#85heehehe wants to merge 7 commits into
heehehe wants to merge 7 commits into
Conversation
Co-authored-by: mjs1995 <munmun2004@naver.com> Co-authored-by: mikaniz <k515jina@gmail.com>
Co-authored-by: starcat37 <starcat37@korea.ac.kr>
Co-authored-by: starcat37 <starcat37@korea.ac.kr>
heehehe
force-pushed
the
feature/typing-gtid-exception-binlogstream-packet
branch
from
cc6ac07 to
0eefeb4
Compare
September 5, 2023 02:51
sean-k1
reviewed
Sep 5, 2023
Comment thread
pymysqlreplication/binlogstream.py
| @@ -66,17 +70,17 @@ def __init__(self, value): | |||
| except KeyError: | |||
| pass | |||
| else: | |||
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
위에서 tuple인 경우를 거르니까 str만 오지않을까 싶습니다!
Sorry, something went wrong.
Co-authored-by: sean-k1 <sean.k1@kakaoent.com>
heehehe
force-pushed
the
feature/typing-gtid-exception-binlogstream-packet
branch
from
0eefeb4 to
b265259
Compare
September 6, 2023 09:14
dongwook-chan
approved these changes
Sep 6, 2023
dongwook-chan
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
3조를 끝으로 typing 마무리 되었네요!! 고생 많으셨습니다!!
Sorry, something went wrong.
Comment thread
pymysqlreplication/binlogstream.py
Outdated
Comment thread
pymysqlreplication/binlogstream.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.