| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
Please address the comments from this code review:
## Overall Comments
- Catching `FileNotFoundError` here is a bit broad; consider catching `importlib.metadata.PackageNotFoundError`/`MetadataNotFound` explicitly (with a fallback to `FileNotFoundError` if needed for compatibility) to avoid masking unrelated filesystem issues.
- Instead of propagating `None` as `dist_metadata` and checking it in multiple places, consider early‐continuing when metadata is missing to keep the control flow simpler and avoid `None` handling further down.
Sorry, something went wrong.
In Python 3.15, importlib.metadata raises MetadataNotFound (a FileNotFoundError subclass) when a dist-info directory has no METADATA file. Previously, it returned None. CPython change: python/cpython#146234
This PR contains the following updates: | Package | Update | Change | Pending | |---|---|---|---| | [poetry](https://github.com/python-poetry/poetry) ([changelog](https://python-poetry.org/history/)) | minor | `2.3.4` → `2.4.0` | `2.4.1` | --- ### Release Notes <details> <summary>python-poetry/poetry (poetry)</summary> ### [`v2.4.0`](https://github.com/python-poetry/poetry/blob/HEAD/CHANGELOG.md#240---2026-05-03) [Compare Source](python-poetry/poetry@2.3.4...2.4.0) ##### Added - Add `solver.min-release-age` setting to require package releases to be a certain number of days old before they are considered during dependency resolution ([#​10824](python-poetry/poetry#10824)). - Add `solver.min-release-age-exclude` to exclude selected packages from age filtering ([#​10824](python-poetry/poetry#10824)). - Add `solver.min-release-age-exclude-source` to exclude all packages from selected package indexes from age filtering ([#​10824](python-poetry/poetry#10824)). ##### Changed - Raise an error instead of silently ignoring a package name that is not a dependency when it is passed to `poetry update` ([#​10721](python-poetry/poetry#10721)). - Automatically add a trailing slash to legacy repository URLs (used for publishing) if missing ([#​10785](python-poetry/poetry#10785)). - Require `installer>=1.0.0` ([#​10869](python-poetry/poetry#10869)). - Allow `findpython>=0.8` ([#​10874](python-poetry/poetry#10874)). ##### Fixed - Fix an issue where `requires-plugins` fails on Windows if scheme paths are on different drives ([#​10869](python-poetry/poetry#10869)). - Fix an issue where the order of markers in the lock file was not deterministic ([#​10720](python-poetry/poetry#10720)). - Fix an issue where the wrong command was suggested when `poetry self` commands failed due to an outdated lock file ([#​10715](python-poetry/poetry#10715)). - Fix an issue where `poetry env activate` did not work for bash on Windows ([#​10716](python-poetry/poetry#10716)). - Fix an issue where `poetry debug resolve` failed when there was a package with a marker ([#​10807](python-poetry/poetry#10807)). - Fix an issue where the error message about a build backend failure contained garbled `--config-settings` ([#​10804](python-poetry/poetry#10804)). - Fix an issue where a false warning about a circular dependency was printed ([#​10811](python-poetry/poetry#10811)). - Fix an issue where falsy config values were incorrectly treated as not set ([#​10808](python-poetry/poetry#10808)). - Fix an issue where `poetry publish --build` ignored failing builds and uploaded stale artifacts ([#​10802](python-poetry/poetry#10802)). - Fix an issue where `poetry publish` was aborted instead of retrying after package registration ([#​10801](python-poetry/poetry#10801)). - Fix an issue where zip files were not closed after fetching metadata via `lazy-wheel` ([#​10800](python-poetry/poetry#10800)). - Fix an issue where data fetched via `lazy-wheel` was corrupted when part of it had already been cached ([#​10806](python-poetry/poetry#10806)). - Fix an issue where further packages were installed even though installation should be aborted ([#​10742](python-poetry/poetry#10742)). - Fix an issue where installed packages without a `METADATA` file caused an exception on Python 3.15+ ([#​10860](python-poetry/poetry#10860)). - Fix an issue where `http-basic` could not be set for repository names with periods ([#​10845](python-poetry/poetry#10845)). - Fix an issue where calculating the hash of large wheels failed with a memory error ([#​10814](python-poetry/poetry#10814)). ##### Docs - Clarify the precedence of configuration sources ([#​10757](python-poetry/poetry#10757)). - Add a note about the influence of `.gitignore` on `tool.poetry.packages` ([#​10835](python-poetry/poetry#10835)). ##### poetry-core ([`2.4.0`](https://github.com/python-poetry/poetry-core/releases/tag/2.4.0)) - Update vendored `packaging` to `26.2` ([#​936](python-poetry/poetry-core#936)). </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNzAuMTkiLCJ1cGRhdGVkSW5WZXIiOiI0My4xNzAuMTkiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://git.walbeck.it/mwalbeck/docker-python-poetry/pulls/1743 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
In Python 3.15, importlib.metadata raises MetadataNotFound
(a FileNotFoundError subclass) when a dist-info directory has no
METADATA file. Previously, it returned None.
CPython change: python/cpython#146234
There is nothing new to test - it's gonna be tested once Python 3.15 is in CI here. Also, there is nothing to add to the documentation.